Re: [PATCH 4/5] time_stats: Promote to lib/

From: "Darrick J. Wong" <djwong@kernel.org>
To: Kent Overstreet <kent.overstreet@linux.dev>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-bcache@vger.kernel.org, linux-bcachefs@vger.kernel.org,
	Dave Chinner <david@fromorbit.com>, Theodore Ts'o <tytso@mit.edu>,
	Coly Li <colyli@suse.de>
Subject: Re: [PATCH 4/5] time_stats: Promote to lib/
Date: Thu, 1 Feb 2024 11:57:17 -0800	[thread overview]
Message-ID: <20240201195717.GF6184@frogsfrogsfrogs> (raw)
In-Reply-To: <20240127015352.GB6184@frogsfrogsfrogs>

Note that I needed the following patch to fix some build errors:

diff --git a/lib/time_stats.c b/lib/time_stats.c
index a5b9f149e2c6a..6618b1c35d700 100644
--- a/lib/time_stats.c
+++ b/lib/time_stats.c
@@ -6,6 +6,7 @@
 #include <linux/time.h>
 #include <linux/time_stats.h>
 #include <linux/spinlock.h>
+#include <linux/module.h>
 
 static const struct time_unit time_units[] = {
 	{ "ns",		1		 },
@@ -29,6 +30,7 @@ const struct time_unit *pick_time_units(u64 ns)
 
 	return u;
 }
+EXPORT_SYMBOL_GPL(pick_time_units);
 
 static void quantiles_update(struct quantiles *q, u64 v)
 {
@@ -262,3 +264,7 @@ void time_stats_init(struct time_stats *stats)
 	spin_lock_init(&stats->lock);
 }
 EXPORT_SYMBOL_GPL(time_stats_init);
+
+MODULE_AUTHOR("Kent Overstreet?");
+MODULE_DESCRIPTION("time statistics library");
+MODULE_LICENSE("GPL");
