From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Minchan Kim <minchan@kernel.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Coly Li <colyli@suse.de>, Vishal Verma <vishal.l.verma@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Dave Jiang <dave.jiang@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
linux-m68k@lists.linux-m68k.org, linux-bcache@vger.kernel.org,
nvdimm@lists.linux.dev, linux-block@vger.kernel.org
Subject: [PATCH 4/9] n64cart: pass queue_limits to blk_mq_alloc_disk
Date: Thu, 15 Feb 2024 08:10:50 +0100 [thread overview]
Message-ID: <20240215071055.2201424-5-hch@lst.de> (raw)
In-Reply-To: <20240215071055.2201424-1-hch@lst.de>
Pass the queue limits directly to blk_alloc_disk instead of setting them
one at a time.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
drivers/block/n64cart.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/block/n64cart.c b/drivers/block/n64cart.c
index c64d7ee7a44db5..27b2187e7a6d55 100644
--- a/drivers/block/n64cart.c
+++ b/drivers/block/n64cart.c
@@ -114,6 +114,10 @@ static const struct block_device_operations n64cart_fops = {
*/
static int __init n64cart_probe(struct platform_device *pdev)
{
+ struct queue_limits lim = {
+ .physical_block_size = 4096,
+ .logical_block_size = 4096,
+ };
struct gendisk *disk;
int err = -ENOMEM;
@@ -131,7 +135,7 @@ static int __init n64cart_probe(struct platform_device *pdev)
if (IS_ERR(reg_base))
return PTR_ERR(reg_base);
- disk = blk_alloc_disk(NULL, NUMA_NO_NODE);
+ disk = blk_alloc_disk(&lim, NUMA_NO_NODE);
if (IS_ERR(disk)) {
err = PTR_ERR(disk);
goto out;
@@ -147,8 +151,6 @@ static int __init n64cart_probe(struct platform_device *pdev)
set_disk_ro(disk, 1);
blk_queue_flag_set(QUEUE_FLAG_NONROT, disk->queue);
- blk_queue_physical_block_size(disk->queue, 4096);
- blk_queue_logical_block_size(disk->queue, 4096);
err = add_disk(disk);
if (err)
--
2.39.2
next prev parent reply other threads:[~2024-02-15 7:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-15 7:10 pass queue_limits to blk_alloc_disk for simple drivers Christoph Hellwig
2024-02-15 7:10 ` [PATCH 1/9] block: pass a queue_limits argument to blk_alloc_disk Christoph Hellwig
2024-02-15 7:10 ` [PATCH 2/9] nfblock: pass queue_limits to blk_mq_alloc_disk Christoph Hellwig
2024-02-15 7:10 ` [PATCH 3/9] brd: " Christoph Hellwig
2024-02-17 0:42 ` Chaitanya Kulkarni
2024-02-15 7:10 ` Christoph Hellwig [this message]
2024-02-17 0:43 ` [PATCH 4/9] n64cart: " Chaitanya Kulkarni
2024-02-15 7:10 ` [PATCH 5/9] zram: " Christoph Hellwig
2024-02-19 12:04 ` Sergey Senozhatsky
2024-02-15 7:10 ` [PATCH 6/9] bcache: " Christoph Hellwig
2024-02-17 0:44 ` Chaitanya Kulkarni
2024-02-15 7:10 ` [PATCH 7/9] btt: " Christoph Hellwig
2024-02-15 18:16 ` Dave Jiang
2024-02-15 7:10 ` [PATCH 8/9] pmem: " Christoph Hellwig
2024-02-15 18:15 ` Dave Jiang
2024-02-17 0:45 ` Chaitanya Kulkarni
2024-02-15 7:10 ` [PATCH 9/9] dcssblk: " Christoph Hellwig
2024-02-15 22:04 ` pass queue_limits to blk_alloc_disk for simple drivers Dan Williams
2024-02-17 0:51 ` Himanshu Madhani
2024-02-20 13:22 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240215071055.2201424-5-hch@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=colyli@suse.de \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=geert@linux-m68k.org \
--cc=ira.weiny@intel.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=minchan@kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=senozhatsky@chromium.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).