linux-bcache.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marco Elver <elver@google.com>
To: Pierre Gondois <pierre.gondois@arm.com>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Arve Hjønnevåg" <arve@android.com>,
	"Todd Kjos" <tkjos@android.com>,
	"Martijn Coenen" <maco@android.com>,
	"Joel Fernandes" <joel@joelfernandes.org>,
	"Christian Brauner" <brauner@kernel.org>,
	"Carlos Llamas" <cmllamas@google.com>,
	"Suren Baghdasaryan" <surenb@google.com>,
	"Coly Li" <colyli@suse.de>,
	"Kent Overstreet" <kent.overstreet@gmail.com>,
	"Kees Cook" <keescook@chromium.org>,
	"Jani Nikula" <jani.nikula@intel.com>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Ingo Molnar" <mingo@kernel.org>,
	linux-bcache@vger.kernel.org
Subject: Re: [PATCH v2 0/3] list: Add hlist_count_nodes()
Date: Mon, 8 Jan 2024 08:00:00 +0100	[thread overview]
Message-ID: <CANpmjNMK3hiBPG2UwEV14YZoee08a7ULw4cwcsxfV=E5+FcTTg@mail.gmail.com> (raw)
In-Reply-To: <CANpmjNOwqoEbmuyE_LeMmJ=x9-3CkpXqYsi6m3Gniudyj+RFzw@mail.gmail.com>

On Thu, 4 Jan 2024 at 18:16, Marco Elver <elver@google.com> wrote:
> On Thu, 4 Jan 2024 at 17:50, Pierre Gondois <pierre.gondois@arm.com> wrote:
> >
> > v2:
> > - Add usages of the function to avoid considering it as dead code.
> > v1:
> > - https://lore.kernel.org/all/20240103090241.164817-1-pierre.gondois@arm.com/
> >
> > Add a generic hlist_count_nodes() function.
> >
> > This function aims to be used in a private module. As suggested by
> > Marco, having it used would avoid to consider it as dead code.
> > Thus, add some usages of the function in two drivers.
>
> Whether or not it's used in a private module is probably irrelevant
> from an upstream perspective.
>
> But this is a reasonable cleanup, and at the same time adds API
> symmetry with the already existing list_count_nodes().
>
> > Pierre Gondois (3):
> >   list: Add hlist_count_nodes()
> >   binder: Use of hlist_count_nodes()
> >   bcache: Use of hlist_count_nodes()
> >
> >  drivers/android/binder.c  |  4 +---
> >  drivers/md/bcache/sysfs.c |  8 +-------
> >  include/linux/list.h      | 15 +++++++++++++++
> >  3 files changed, 17 insertions(+), 10 deletions(-)
>
> For the series:
>
> Acked-by: Marco Elver <elver@google.com>

Btw, there doesn't appear to be a clear maintainer or tree for
include/linux/list.h. Since there have been several Acks/Reviews by
now, did you have a particular tree in mind?
Perhaps Andrew (+Cc) can help.

Thanks,
-- Marco

  reply	other threads:[~2024-01-08  7:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-04 16:49 [PATCH v2 0/3] list: Add hlist_count_nodes() Pierre Gondois
2024-01-04 16:49 ` [PATCH v2 1/3] " Pierre Gondois
2024-01-04 17:30   ` Carlos Llamas
2024-01-05  6:53   ` Coly Li
2024-01-04 16:49 ` [PATCH v2 2/3] binder: Use of hlist_count_nodes() Pierre Gondois
2024-01-04 17:31   ` Carlos Llamas
2024-01-04 16:49 ` [PATCH v2 3/3] bcache: " Pierre Gondois
2024-01-05  6:55   ` Coly Li
2024-01-06 14:36   ` Andy Shevchenko
2024-01-04 17:16 ` [PATCH v2 0/3] list: Add hlist_count_nodes() Marco Elver
2024-01-08  7:00   ` Marco Elver [this message]
2024-01-06 14:37 ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANpmjNMK3hiBPG2UwEV14YZoee08a7ULw4cwcsxfV=E5+FcTTg@mail.gmail.com' \
    --to=elver@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=arve@android.com \
    --cc=brauner@kernel.org \
    --cc=cmllamas@google.com \
    --cc=colyli@suse.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=jani.nikula@intel.com \
    --cc=joel@joelfernandes.org \
    --cc=keescook@chromium.org \
    --cc=kent.overstreet@gmail.com \
    --cc=linux-bcache@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maco@android.com \
    --cc=mingo@kernel.org \
    --cc=pierre.gondois@arm.com \
    --cc=surenb@google.com \
    --cc=tkjos@android.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).