From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4148E69E05 for ; Wed, 20 Mar 2024 17:13:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710954832; cv=none; b=mg5erZGaHqvHoHomM877d1t/7vZInrZ8dxintzr3sNh2zWzi81CprAvGMepe7ZPJG8qf6jWX9q5ElDgCEbpeTuV8UKj7Cof5fJhigzIhm9VYtsX4xMM0VoMZsiQ21LcehNy/+tvu04dGdCRBQWpNSKu8SfYynC82BM4rxc/QjA0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710954832; c=relaxed/simple; bh=Z2QMshSRUV/Ic6Kf5osNo4mJkuPuXiVLb5k5is3/ucs=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=vBfnGSWASa/HHfi8XlrpktGR76TOehy7upWTO2OutI5L4cfL1DB85hB+vyv5OJ86JUlBAAvsEANH81tQjGbMDqdACmVRnN4rsU/VWOkL5xFPRDilEYYVUywCFePjad6BtOLHPZ2mL5njfDtp3+Pwp49PnZvrvmeM3GGMiMIO1OI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=ZK+zV9NB; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ZK+zV9NB" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-1e058b9e479so8715ad.0 for ; Wed, 20 Mar 2024 10:13:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1710954830; x=1711559630; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=f+GdX2jdkDlWHWBVOsGIoAg8YOz++4sTFpjiRVGx7IY=; b=ZK+zV9NBZTGdUYxJDa0k4CUSddFVcRdznVDuyaWV2v9j+WFlVMsdDdBRV1L+CmxX0X bmo3Z+MMeBnkO3FqSMVNsTJM9g0iCFHq+bJV5VX6JYMsm5Kw8EGBjbfn4Jhb1bWwYgaD Prrgc0ja1NiG3CP++dvo52ABLpFt1wXJ5vJUy3DpvJFa8pScbd7ZK0Dz9uv+7OTPxbTh JosWOiQdZuEBKQi9XlkDxbR1Ch6d5jdqza0hkWfrNRwFKqR9jganS7bPoT9mihccCGHZ 2n788+mQpUecUZ1ErlGOyPm55tcvJn8L52TNtou7B0KHq84EF4neGpyOA0mpqBJ/4DMF rb/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710954830; x=1711559630; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=f+GdX2jdkDlWHWBVOsGIoAg8YOz++4sTFpjiRVGx7IY=; b=mc/sPkT1VbXpZpsi6CigxHq2ErTffYl/pW3tbGnxZeHRj0JX8jxMqgdX53rozR/tZt vWWOEovLpgN045iFZQu+8HAsorR2tdHHxwWDO29J5FLQMqPjvMyVEv/G2CCovYt2pHef aKQx1XLGB8Yj4qPH9FIpeA/jSMRZbchNgqmvEInxgRnb+fa+1q+SWVOCKAPdla9klA5Z zl1Zsjkq4GwlH5q2hh1QhCFx7ci7zLe9P1J1LLrkv9L1md3R2v2m8irguL9hpn6moAxe Fyi05Fu3rpLO+Grh4j5bshpiBv/Zo6GOV1QSBcM+rJFsIpex+0tIdawA1PWox809LCYF hDkg== X-Forwarded-Encrypted: i=1; AJvYcCWvc/GPP12mz//4ooPXXVmzaDVNojQCtnsLSE593jUq0b696c9GtfZhS7cOaBcOv3kWDh8EeZKtjRCND219EbA+LlO/nzm2ySROvLNH X-Gm-Message-State: AOJu0YxCdPk/b88CNZDQwVXzu2Cc/ecZM0LPTzkvfjucU6mOVE1C3P0y ZuXMTZw1FrYcFvkNr0mKNoTF8nqevu9fHZXdnW/ugLyMUzr/5Fgzn5lFPBExZvFnPWr8wvcFrm4 tEtIGPpiRFssFWNvPJoltCWGHxQkM375di1DC X-Google-Smtp-Source: AGHT+IH0qAID20MP6jp6NpXqn9mW2kuq00RtO9yb0PwCHdZ99yKuZBY632oWoHKU4JglvZUaklYHu5xGsWpmsCAynaA= X-Received: by 2002:a17:902:6805:b0:1de:fdbd:930d with SMTP id h5-20020a170902680500b001defdbd930dmr312651plk.16.1710954830070; Wed, 20 Mar 2024 10:13:50 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-bcache@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240320145417.336208-1-visitorckw@gmail.com> <20240320145417.336208-6-visitorckw@gmail.com> In-Reply-To: <20240320145417.336208-6-visitorckw@gmail.com> From: Ian Rogers Date: Wed, 20 Mar 2024 10:13:38 -0700 Message-ID: Subject: Re: [PATCH v2 05/15] lib min_heap: Add min_heap_init() To: Kuan-Wei Chiu Cc: colyli@suse.de, kent.overstreet@linux.dev, msakai@redhat.com, peterz@infradead.org, mingo@redhat.com, acme@kernel.org, namhyung@kernel.org, akpm@linux-foundation.org, bfoster@redhat.com, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, adrian.hunter@intel.com, jserv@ccns.ncku.edu.tw, dm-devel@lists.linux.dev, linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org, linux-bcachefs@vger.kernel.org, linux-perf-users@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Mar 20, 2024 at 7:54=E2=80=AFAM Kuan-Wei Chiu wrote: > > Add min_heap_init() for initializing heap with data, nr, and size. > > Signed-off-by: Kuan-Wei Chiu Thanks, is it possible to update lib/test_min_heap.c to use min_heap_init? Ian > --- > include/linux/min_heap.h | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/include/linux/min_heap.h b/include/linux/min_heap.h > index c3635a7fdb88..ed462f194b88 100644 > --- a/include/linux/min_heap.h > +++ b/include/linux/min_heap.h > @@ -44,6 +44,18 @@ struct min_heap_callbacks { > void (*swp)(void *lhs, void *rhs); > }; > > +/* Initialize a min-heap. */ > +static __always_inline > +void __min_heap_init(struct __min_heap *heap, void *data, int size) > +{ > + heap->data =3D data; > + heap->nr =3D 0; > + heap->size =3D size; > +} > + > +#define min_heap_init(_heap, _data, _size) \ > + __min_heap_init(&(_heap)->heap, _data, _size) > + > /* Sift the element at pos down the heap. */ > static __always_inline > void __min_heapify(struct __min_heap *heap, int pos, size_t elem_size, > -- > 2.34.1 >