From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE3DDC433F5 for ; Wed, 13 Oct 2021 21:14:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8C89561175 for ; Wed, 13 Oct 2021 21:14:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230123AbhJMVQu (ORCPT ); Wed, 13 Oct 2021 17:16:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:44862 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230111AbhJMVQt (ORCPT ); Wed, 13 Oct 2021 17:16:49 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id BCD7761139; Wed, 13 Oct 2021 21:14:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634159685; bh=SlbEmP0SftpYg5Qzgl+3uhbNwtKN42MS1eJbqRVvz8o=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=hiKscGct16rhTAVFUvB8ulUGFNYX0XJpF+2YqPKF0No0/OTxa8B+FbCYvPeznM3IT o7+9DVjPYoKAxa50QdWsJ1gL4J+4wBU1jNZrm6P/FvNKQ8G7E2qrXO9VM2GBzVJvw8 S/gFZjYpmMou1VruRE19i94wuylZi24lJbQ6yAN6OeRqXntYIE5B0JYh+T/uz9ctke L86OtKTf7XCkJxLOyXfeIFv5kZLrR3s6zlWx8Mcxq8cYKDBsASwSQxb8GUZPcnzqgT VFHmPHbz4NrsEHQ/qmk1iEmYL+m9W0ImnKdxKKKAOXKE+hMXaoTAVCJomjq0s1kTjo 7pgsY+NMeWiSg== Received: by mail-lf1-f54.google.com with SMTP id u18so17428163lfd.12; Wed, 13 Oct 2021 14:14:45 -0700 (PDT) X-Gm-Message-State: AOAM532FXiGs1sCaGxNpzsJmeQlJzE+mAIiSokLdcbxAMrOP9h09k+b9 RNkm7JcYnOu/qJ5EjWa83slixpHkeaKf2YthUvI= X-Google-Smtp-Source: ABdhPJy4PwudaFsA5k7zIKbmlSW7M8/j3iWHJKEthDYdjnMO754KPa3JLlK+wmXJkye7TEJ2vXHzCCixulymuZnDiqk= X-Received: by 2002:a2e:6e0b:: with SMTP id j11mr1736234ljc.527.1634159683768; Wed, 13 Oct 2021 14:14:43 -0700 (PDT) MIME-Version: 1.0 References: <20211013051042.1065752-1-hch@lst.de> <20211013051042.1065752-5-hch@lst.de> <202110122311.B43459E21@keescook> In-Reply-To: <202110122311.B43459E21@keescook> From: Song Liu Date: Wed, 13 Oct 2021 14:14:32 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 04/29] md: use bdev_nr_sectors instead of open coding it To: Kees Cook Cc: Christoph Hellwig , Jens Axboe , Coly Li , Mike Snitzer , David Sterba , Josef Bacik , "Theodore Ts'o" , OGAWA Hirofumi , Dave Kleikamp , Ryusuke Konishi , Anton Altaparmakov , Konstantin Komarov , Phillip Lougher , Jan Kara , linux-block@vger.kernel.org, dm-devel@redhat.com, drbd-dev@lists.linbit.com, linux-bcache@vger.kernel.org, linux-raid , linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, Linux-Fsdevel , linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net, ntfs3@lists.linux.dev, reiserfs-devel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-bcache@vger.kernel.org On Tue, Oct 12, 2021 at 11:12 PM Kees Cook wrote: > > On Wed, Oct 13, 2021 at 07:10:17AM +0200, Christoph Hellwig wrote: > > Use the proper helper to read the block device size. > > > > Signed-off-by: Christoph Hellwig > > I think it might make sense, as you suggest earlier, to add a "bytes" > helper. This is the first user in the series needing: > > bdev_nr_sectors(...bdev) << SECTOR_SHIFT > > Reviewed-by: Kees Cook Acked-by: Song Liu