linux-bcachefs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kent Overstreet <kent.overstreet@linux.dev>
To: linux-bcachefs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	 linux-kernel@vger.kernel.org
Subject: bcachefs: do not run 6.7: upgrade to 6.8 immediately if you have a multi device fs
Date: Fri, 15 Mar 2024 00:41:09 -0400	[thread overview]
Message-ID: <muwlfryvafsskt2l2hgv3szwzjfn7cswmmnoka6zlpz2bxj6lh@ugceww4kv3jr> (raw)

there's a bug in 6.7 with filesystems that are mid upgrade and then get
downgraded not getting marked in the superblock as downgraded, and this
translates to a really horrific bug in splitbrain detection when the old
version isn't updating member sequence nmubers and you go back to the
new version - this results in every device being kicked out of the fs.

and our backports are not being picked up by the stable team, so - do
not run 6.7, switch to 6.8 immediately, running 6.7 with new -tools will
trigger it.

if you are affected:

 - 6.9 (once Linus merges) will have a new no_splitbrain_check option,
   which runs the splitbrain checks in dry mode and won't kick your
   devices out

 - we have new repair code landing soon that can recover from
   missing/unreadable btree roots by scanning the entire device(s) for
   btree nodes (which, fortunately, we have sufficient metadata in btree
   node headers to do safely; reiserfs famously did not). i've seen some
   crazy corruption resulting from this, but it might still be
   recoverable

             reply	other threads:[~2024-03-15  4:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-15  4:41 Kent Overstreet [this message]
2024-03-15  8:57 ` bcachefs: do not run 6.7: upgrade to 6.8 immediately if you have a multi device fs Martin Steigerwald
2024-03-15 17:57   ` Kent Overstreet
2024-03-16 16:18     ` Martin Steigerwald
2024-03-16 16:41       ` Kent Overstreet
2024-03-16 16:49         ` Martin Steigerwald
2024-03-16 17:31           ` Martin Steigerwald
2024-03-16 18:08             ` Kent Overstreet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=muwlfryvafsskt2l2hgv3szwzjfn7cswmmnoka6zlpz2bxj6lh@ugceww4kv3jr \
    --to=kent.overstreet@linux.dev \
    --cc=linux-bcachefs@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).