From: Hannes Reinecke <hare@suse.de>
To: Marcos Paulo de Souza <marcos.souza.org@gmail.com>,
linux-kernel@vger.kernel.org
Cc: linux-block@vger.kernel.org, linux-doc@vger.kernel.org,
Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH 1/4] block: elevator.c: Remove now unused elevator= argument
Date: Fri, 19 Jul 2019 15:36:27 +0200 [thread overview]
Message-ID: <081e9968-0ca5-6c3e-fac7-4eb701c415fa@suse.de> (raw)
In-Reply-To: <20190714053453.1655-2-marcos.souza.org@gmail.com>
On 7/14/19 7:34 AM, Marcos Paulo de Souza wrote:
> Since the inclusion of blk-mq, elevator argument was not being
> considered anymore, and it's utility died long with the legacy IO path,
> now removed too.
>
> Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
> ---
> block/elevator.c | 14 --------------
> 1 file changed, 14 deletions(-)
>
> diff --git a/block/elevator.c b/block/elevator.c
> index 2f17d66d0e61..f56d9c7d5cbc 100644
> --- a/block/elevator.c
> +++ b/block/elevator.c
> @@ -135,20 +135,6 @@ static struct elevator_type *elevator_get(struct request_queue *q,
> return e;
> }
>
> -static char chosen_elevator[ELV_NAME_MAX];
> -
> -static int __init elevator_setup(char *str)
> -{
> - /*
> - * Be backwards-compatible with previous kernels, so users
> - * won't get the wrong elevator.
> - */
> - strncpy(chosen_elevator, str, sizeof(chosen_elevator) - 1);
> - return 1;
> -}
> -
> -__setup("elevator=", elevator_setup);
> -
> static struct kobj_type elv_ktype;
>
> struct elevator_queue *elevator_alloc(struct request_queue *q,
>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)
next prev parent reply other threads:[~2019-07-19 13:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-14 5:34 [PATCH 0/4] Remove elevator kernel parameter Marcos Paulo de Souza
2019-07-14 5:34 ` [PATCH 1/4] block: elevator.c: Remove now unused elevator= argument Marcos Paulo de Souza
2019-07-19 13:36 ` Hannes Reinecke [this message]
2019-07-22 23:51 ` Bob Liu
2019-07-14 5:34 ` [PATCH 2/4] kernel-parameters.txt: Remove elevator argument Marcos Paulo de Souza
2019-07-19 13:36 ` Hannes Reinecke
2019-07-14 5:34 ` [PATCH 3/4] Documenation: switching-sched: Remove notes about " Marcos Paulo de Souza
2019-07-19 13:37 ` Hannes Reinecke
2019-07-14 5:34 ` [PATCH 4/4] Documentation:kernel-per-CPU-kthreads.txt: Remove reference to elevator= Marcos Paulo de Souza
2019-07-19 13:37 ` Hannes Reinecke
2019-07-25 20:04 ` [PATCH 0/4] Remove elevator kernel parameter Marcos Paulo de Souza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=081e9968-0ca5-6c3e-fac7-4eb701c415fa@suse.de \
--to=hare@suse.de \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcos.souza.org@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).