From: Jens Axboe <axboe@kernel.dk>
To: Jackie Liu <liuyun01@kylinos.cn>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH v2] io_uring: run dependent links inline if possible
Date: Sun, 29 Sep 2019 19:03:28 -0600 [thread overview]
Message-ID: <0dbbd933-a5a5-536b-40f5-302ec24143a8@kernel.dk> (raw)
In-Reply-To: <84D443CE-9F9B-4677-A3B7-E212F95C044B@kylinos.cn>
On 9/30/19 2:52 AM, Jackie Liu wrote:
> Cool performance improvement, Reviewed-by: Jackie Liu <liuyun01@kylinos.cn>
Thanks for the review.
> BTW, we always use s->needs_lock to determine if it is in async. Is it
> possible to consider replacing it directly with s->in_async?
Yeah I think that'd be a good cleanup, would make it clearer without
needing comments to say that they are equivalent.
--
Jens Axboe
prev parent reply other threads:[~2019-09-30 1:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-29 14:54 [PATCH v2] io_uring: run dependent links inline if possible Jens Axboe
2019-09-30 0:37 ` Jackie Liu
2019-09-30 0:42 ` Jens Axboe
2019-09-30 0:52 ` Jackie Liu
2019-09-30 1:03 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0dbbd933-a5a5-536b-40f5-302ec24143a8@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=liuyun01@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).