From: Jens Axboe <axboe@kernel.dk>
To: Pavel Begunkov <asml.silence@gmail.com>,
io-uring@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: [PATCH 2/3] io_uring: Use submit info inlined into req
Date: Tue, 5 Nov 2019 16:42:38 -0700 [thread overview]
Message-ID: <130e2396-aae9-cda6-f087-7c11ac5b1e5d@kernel.dk> (raw)
In-Reply-To: <32cc59cefc848ba2e258fc4581684f1c2e67d649.1572993994.git.asml.silence@gmail.com>
On 11/5/19 4:04 PM, Pavel Begunkov wrote:
if (unlikely(!shadow_req))
> @@ -2716,24 +2712,25 @@ static int io_submit_sqes(struct io_ring_ctx *ctx, unsigned int nr,
> shadow_req->flags |= (REQ_F_IO_DRAIN | REQ_F_SHADOW_DRAIN);
> refcount_dec(&shadow_req->refs);
> }
> - shadow_req->sequence = s.sequence;
> + shadow_req->sequence = req->submit.sequence;
> }
>
> out:
> - s.ring_file = ring_file;
> - s.ring_fd = ring_fd;
> - s.has_user = *mm != NULL;
> - s.in_async = async;
> - s.needs_fixed_file = async;
> - trace_io_uring_submit_sqe(ctx, s.sqe->user_data, true, async);
> - io_submit_sqe(ctx, req, &s, statep, &link);
> + req->submit.ring_file = ring_file;
> + req->submit.ring_fd = ring_fd;
> + req->submit.has_user = *mm != NULL;
> + req->submit.in_async = async;
> + req->submit.needs_fixed_file = async;
> + trace_io_uring_submit_sqe(ctx, req->submit.sqe->user_data,
> + true, async);
> + io_submit_sqe(ctx, req, &req->submit, statep, &link);
> submitted++;
>
> /*
> * If previous wasn't linked and we have a linked command,
> * that's the end of the chain. Submit the previous link.
> */
> - if (!(s.sqe->flags & IOSQE_IO_LINK) && link) {
> + if (!(req->submit.sqe->flags & IOSQE_IO_LINK) && link) {
> io_queue_link_head(ctx, link, &link->submit, shadow_req);
> link = NULL;
> shadow_req = NULL;
Another potential use-after-free here, as 'req' might have completed by
the time you go and check for IOSQE_IO_LINK.
--
Jens Axboe
next prev parent reply other threads:[~2019-11-05 23:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-05 23:04 [RFC 0/3] Inline sqe_submit Pavel Begunkov
2019-11-05 23:04 ` [PATCH 1/3] io_uring: allocate io_kiocb upfront Pavel Begunkov
2019-11-05 23:04 ` [PATCH 2/3] io_uring: Use submit info inlined into req Pavel Begunkov
2019-11-05 23:42 ` Jens Axboe [this message]
2019-11-05 23:04 ` [PATCH 3/3] io_uring: use inlined struct sqe_submit Pavel Begunkov
2019-11-05 23:37 ` Jens Axboe
2019-11-05 23:43 ` Pavel Begunkov
2019-11-05 23:37 ` [RFC 0/3] Inline sqe_submit Jens Axboe
2019-11-05 23:45 ` Pavel Begunkov
2019-11-05 23:48 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=130e2396-aae9-cda6-f087-7c11ac5b1e5d@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=io-uring@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).