Looks good Reviewed-by: Jon Derrick On Fri, 2019-02-01 at 21:50 +0100, David Kozub wrote: > From: Jonas Rabenstein > > Also the values of OPAL_UID_LENGTH and OPAL_METHOD_LENGTH are the same, > it is weird to use OPAL_UID_LENGTH for the definition of the methods. > > Signed-off-by: Jonas Rabenstein > Reviewed-by: Scott Bauer > --- > block/sed-opal.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block/sed-opal.c b/block/sed-opal.c > index c882a193e162..5c123a5b4ab1 100644 > --- a/block/sed-opal.c > +++ b/block/sed-opal.c > @@ -181,7 +181,7 @@ static const u8 opaluid[][OPAL_UID_LENGTH] = { > * Derived from: TCG_Storage_Architecture_Core_Spec_v2.01_r1.00 > * Section: 6.3 Assigned UIDs > */ > -static const u8 opalmethod[][OPAL_UID_LENGTH] = { > +static const u8 opalmethod[][OPAL_METHOD_LENGTH] = { > [OPAL_PROPERTIES] = > { 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xff, 0x01 }, > [OPAL_STARTSESSION] =