From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Dongli Zhang <dongli.zhang@oracle.com>
Cc: <xen-devel@lists.xenproject.org>, <linux-block@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <konrad.wilk@oracle.com>,
<axboe@kernel.dk>
Subject: Re: [PATCH 1/1] xen-blkback: do not wake up shutdown_wq after xen_blkif_schedule() is stopped
Date: Wed, 16 Jan 2019 15:29:43 +0100 [thread overview]
Message-ID: <20190116142943.b4nlpoaeitn6esb2@mac> (raw)
In-Reply-To: <1547646461-29803-1-git-send-email-dongli.zhang@oracle.com>
On Wed, Jan 16, 2019 at 09:47:41PM +0800, Dongli Zhang wrote:
> There is no need to wake up xen_blkif_schedule() as kthread_stop() is able
> to already wake up the kernel thread.
>
> Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
kthread_stop waits for the thread to exit, so it must obviously wake
it up.
Thanks, Roger.
next prev parent reply other threads:[~2019-01-16 14:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-16 13:47 [PATCH 1/1] xen-blkback: do not wake up shutdown_wq after xen_blkif_schedule() is stopped Dongli Zhang
2019-01-16 14:29 ` Roger Pau Monné [this message]
2019-01-16 14:52 ` Roger Pau Monné
2019-01-17 2:10 ` [Xen-devel] " Dongli Zhang
2019-01-17 8:20 ` Roger Pau Monné
2019-01-17 10:23 ` Dongli Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190116142943.b4nlpoaeitn6esb2@mac \
--to=roger.pau@citrix.com \
--cc=axboe@kernel.dk \
--cc=dongli.zhang@oracle.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).