From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Petr Mladek <pmladek@suse.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
scsi <linux-scsi@vger.kernel.org>,
Linux PM list <linux-pm@vger.kernel.org>,
Linux MMC List <linux-mmc@vger.kernel.org>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
linux-um@lists.infradead.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-block@vger.kernel.org,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
linux-btrfs <linux-btrfs@vger.kernel.org>,
linux-pci <linux-pci@vger.kernel.org>,
sparclinux <sparclinux@vger.kernel.org>,
xen-devel@lists.xenproject.org,
ceph-devel <ceph-devel@vger.kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Linux MM <linux-mm@kvack.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Lars Ellenberg <drbd-dev@lists.linbit.com>
Subject: Re: [PATCH 0/2] Remove support for deprecated %pf and %pF in vsprintf
Date: Fri, 22 Mar 2019 15:53:50 +0200 [thread overview]
Message-ID: <20190322135350.2btpno7vspvewxvk@paasikivi.fi.intel.com> (raw)
In-Reply-To: <CAMuHMdVmqqjVx7As9AAywYxYXG=grijF5rF77OBn6TUjM9+xKw@mail.gmail.com>
Hi Geert,
On Fri, Mar 22, 2019 at 02:37:18PM +0100, Geert Uytterhoeven wrote:
> Hi Sakari,
>
> On Fri, Mar 22, 2019 at 2:25 PM Sakari Ailus
> <sakari.ailus@linux.intel.com> wrote:
> > The printk family of functions supports %ps and %pS conversion specifiers
> > to print function names. Yet the deprecated %pf and %pF conversion
> > specifiers with equivalent functionality remain supported. A number of
> > users of %pf and %pF remain.
> >
> > This patchsets converts the existing users of %pf and %pF to %ps and %pS,
> > respectively, and removes support for the deprecated %pf and %pF.
> >
> > The patches apply cleanly both on 5.1-rc1 as well as on Linux-next. No new
> > %pf or %pF users have been added in the meantime so the patch is
> > sufficient as itself on linux-next, too.
>
> Do you know in which commit they became deprecated, so the backporters
> know how far this can be backported safely?
That appears to be 04b8eb7a4ccd
("symbol lookup: introduce dereference_symbol_descriptor()"), the same
patch that made %p[fF] and %p[sS] functionally equivalent.
But my personal opinion would be not to backport the patch for two reasons:
the sheer number of files it touches (those format strings change for
various reasons) and the meager benefits it has on older kernels as any
backported patch using %s or %S still works as such. Porting a patch
forward should have no issues either as checkpatch.pl has been complaining
of the use of %pf and %pF for a while now.
--
Kind regards,
Sakari Ailus
sakari.ailus@linux.intel.com
next prev parent reply other threads:[~2019-03-22 13:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-22 13:21 [PATCH 0/2] Remove support for deprecated %pf and %pF in vsprintf Sakari Ailus
2019-03-22 13:21 ` [PATCH 1/2] treewide: Switch printk users from %pf and %pF to %ps and %pS, respectively Sakari Ailus
2019-03-22 14:30 ` David Sterba
2019-03-22 21:30 ` Mike Rapoport
2019-03-25 9:33 ` Rafael J. Wysocki
2019-03-22 13:21 ` [PATCH 2/2] vsprintf: Remove support for %pF and %pf in favour of %pS and %ps Sakari Ailus
2019-03-25 9:30 ` Rafael J. Wysocki
2019-03-25 9:49 ` Rafael J. Wysocki
2019-03-22 13:37 ` [PATCH 0/2] Remove support for deprecated %pf and %pF in vsprintf Geert Uytterhoeven
2019-03-22 13:53 ` Sakari Ailus [this message]
2019-03-22 17:05 ` Andy Shevchenko
2019-03-24 21:10 ` Sakari Ailus
2019-03-24 21:19 ` Andy Shevchenko
2019-03-25 15:13 ` Sakari Ailus
2019-03-25 15:24 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190322135350.2btpno7vspvewxvk@paasikivi.fi.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ceph-devel@vger.kernel.org \
--cc=drbd-dev@lists.linbit.com \
--cc=geert@linux-m68k.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=sparclinux@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).