From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB699C4321A for ; Sat, 29 Jun 2019 16:29:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CB3402075B for ; Sat, 29 Jun 2019 16:29:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726860AbfF2Q3S (ORCPT ); Sat, 29 Jun 2019 12:29:18 -0400 Received: from bout01.mta.xmission.com ([166.70.11.15]:49497 "EHLO bout01.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726837AbfF2Q3S (ORCPT ); Sat, 29 Jun 2019 12:29:18 -0400 Received: from mx01.mta.xmission.com ([166.70.13.211]) by bout01.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.87) (envelope-from ) id 1hhG56-0007Mh-5o; Sat, 29 Jun 2019 10:20:04 -0600 Received: from plesk14-shared.xmission.com ([166.70.198.161] helo=plesk14.xmission.com) by mx01.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1hhG55-0001fp-KZ; Sat, 29 Jun 2019 10:20:04 -0600 Received: from hacktheplanet (unknown [73.58.156.118]) by plesk14.xmission.com (Postfix) with ESMTPSA id 6A5A7193226; Sat, 29 Jun 2019 16:20:02 +0000 (UTC) Date: Sat, 29 Jun 2019 12:19:55 -0400 From: Scott Bauer To: axboe@kernel.dk Cc: jonathan.derrick@intel.com, "linux-kernel@vger.kernel.org" , "zub@linux.fjfi.cvut.cz" , "linux-block@vger.kernel.org" , "jonas.rabenstein@studium.uni-erlangen.de" Message-ID: <20190629161947.GA20127@hacktheplanet> References: <1558471606-25139-1-git-send-email-zub@linux.fjfi.cvut.cz> <7ee5d705c12d770bf7566bce7d664bf733b25206.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7ee5d705c12d770bf7566bce7d664bf733b25206.camel@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-XM-SPF: eid=1hhG55-0001fp-KZ;;;mid=<20190629161947.GA20127@hacktheplanet>;;;hst=mx01.mta.xmission.com;;;ip=166.70.198.161;;;frm=sbauer@plzdonthack.me;;;spf=none X-SA-Exim-Connect-IP: 166.70.198.161 X-SA-Exim-Mail-From: sbauer@plzdonthack.me Subject: Re: [PATCH v2 0/3] block: sed-opal: add support for shadow MBR done flag and write X-SA-Exim-Version: 4.2.1 (built Mon, 03 Jun 2019 09:49:16 -0600) X-SA-Exim-Scanned: Yes (on mx01.mta.xmission.com) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org Hey Jens, Can you please stage these for 5.3 aswell? On Tue, Jun 25, 2019 at 08:47:26PM +0000, Derrick, Jonathan wrote: > These are still good with me and we'll likely have a similar future use > for passing data through the ioctl. > > Could we get this staged for 5.3? > > On Tue, 2019-05-21 at 22:46 +0200, David Kozub wrote: > > This patch series extends SED Opal support: it adds IOCTL for setting the shadow > > MBR done flag which can be useful for unlocking an Opal disk on boot and it adds > > IOCTL for writing to the shadow MBR. > > > > This applies on current master. > > > > I successfully tested toggling the MBR done flag and writing the shadow MBR > > using some tools I hacked together[1] with a Samsung SSD 850 EVO drive. > > > > Changes from v1: > > * PATCH 2/3: remove check with access_ok, just rely on copy_from_user as > > suggested in [2] (I tested passing data == 0 and I got the expected EFAULT) > > > > [1] https://gitlab.com/zub2/opalctl > > [2] https://lore.kernel.org/lkml/20190501134833.GB24132@infradead.org/ > > > > Jonas Rabenstein (3): > > block: sed-opal: add ioctl for done-mark of shadow mbr > > block: sed-opal: ioctl for writing to shadow mbr > > block: sed-opal: check size of shadow mbr > > > > block/opal_proto.h | 16 ++++ > > block/sed-opal.c | 157 +++++++++++++++++++++++++++++++++- > > include/linux/sed-opal.h | 2 + > > include/uapi/linux/sed-opal.h | 20 +++++ > > 4 files changed, 193 insertions(+), 2 deletions(-) > >