From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96DDAC4CECD for ; Tue, 17 Sep 2019 15:42:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 645D921897 for ; Tue, 17 Sep 2019 15:42:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568734928; bh=Cs9d1NkB4qUoDkwuZrTgkp77GLRkyvP7Xqf3CmGIlKE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=fCu/CA+YTSpDuBlAmtcB2efP141iE4OW7sC7TymH+SZ1LvRvhJItmAlkeAIjtQx1p EzPwQzwWH4GplQCSSG2d9G9iLEtVk2/EnjKzxbiaRg4jJvy2MwkYQ2oA1fqcQAEGAs 5TzfZH6jZHrh+0TWJnvYdbKkotdoilcyIX6UNl28= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729702AbfIQPmH (ORCPT ); Tue, 17 Sep 2019 11:42:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:60618 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729699AbfIQPmH (ORCPT ); Tue, 17 Sep 2019 11:42:07 -0400 Received: from localhost (unknown [77.137.89.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D2CB52171F; Tue, 17 Sep 2019 15:42:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568734926; bh=Cs9d1NkB4qUoDkwuZrTgkp77GLRkyvP7Xqf3CmGIlKE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=niTsgqzBynMTMZ7IJhyt0HpXRowaAMQxofie64ypEQI5fNX5hLevcX664d2xTgcQa MH8w8RndhWSoUa7pBrkUMYdyiua6yGiphKlLZk4rKB1Uo1SsaxqpwxmhhT4VcxGKZD v26Q9NJYrgFU7dVJOVwfaowWmsRnzZxmUkKrKtw0= Date: Tue, 17 Sep 2019 18:41:50 +0300 From: Leon Romanovsky To: Bart Van Assche Cc: Jinpu Wang , Jack Wang , linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, Jens Axboe , Christoph Hellwig , Sagi Grimberg , Jason Gunthorpe , Doug Ledford , Danil Kipnis , rpenyaev@suse.de, Roman Pen Subject: Re: [PATCH v4 15/25] ibnbd: private headers with IBNBD protocol structs and helpers Message-ID: <20190917154150.GE18203@unreal> References: <20190620150337.7847-1-jinpuwang@gmail.com> <20190620150337.7847-16-jinpuwang@gmail.com> <4fbad80b-f551-131e-9a5c-a24f1fa98fea@acm.org> <20190916052729.GB18203@unreal> <25bd79e1-9523-8354-873a-0ff1db92659a@acm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <25bd79e1-9523-8354-873a-0ff1db92659a@acm.org> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Mon, Sep 16, 2019 at 06:45:17AM -0700, Bart Van Assche wrote: > On 9/15/19 10:27 PM, Leon Romanovsky wrote: > > On Sun, Sep 15, 2019 at 04:30:04PM +0200, Jinpu Wang wrote: > > > On Sat, Sep 14, 2019 at 12:10 AM Bart Van Assche wrote: > > > > > +/* TODO: should be configurable */ > > > > > +#define IBTRS_PORT 1234 > > > > > > > > How about converting this macro into a kernel module parameter? > > > Sounds good, will do. > > > > Don't rush to do it and defer it to be the last change before merging, > > this is controversial request which not everyone will like here. > > Hi Leon, > > If you do not agree with changing this macro into a kernel module parameter > please suggest an alternative. I didn't review code so my answer can be not fully accurate, but opening some port to use this IB* seems strange from my non-sysadmin POV. What about using RDMA-CM, like NVMe? Thanks > > Thanks, > > Bart.