From: Tejun Heo <tj@kernel.org>
To: "Michal Koutný" <mkoutny@suse.com>
Cc: hannes@cmpxchg.org, clm@fb.com, dennisz@fb.com,
Josef Bacik <jbacik@fb.com>,
kernel-team@fb.com, newella@fb.com, lizefan@huawei.com,
axboe@kernel.dk, Paolo Valente <paolo.valente@linaro.org>,
Rik van Riel <riel@surriel.com>,
josef@toxicpanda.com, cgroups@vger.kernel.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 08/10] blkcg: implement blk-iocost
Date: Thu, 3 Oct 2019 09:45:52 -0700 [thread overview]
Message-ID: <20191003164552.GA3247445@devbig004.ftw2.facebook.com> (raw)
In-Reply-To: <20191003145106.GC6678@blackbody.suse.cz>
Hello,
On Thu, Oct 03, 2019 at 04:51:06PM +0200, Michal Koutný wrote:
> > Initially, I put them under block device sysfs but it was too clumsy
> > with different config file formats and all.
> Do you have any more details on that? In the end, it all boils down to a
> daemon/setup utility writing into the control files and it can use
> whatever config files it decides, can't it?
Yeah, I mean, we can make any interface work. So, there are two
global knobs io.cost.model and io.cost.qos. Of the tw, io.cost.model
is okay to move under block device but the qos file gets weird because
the content of the file is more resource control policies than device
properties.
Thanks.
--
tejun
next prev parent reply other threads:[~2019-10-03 17:00 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 22:05 [PATCHSET v3 block/for-linus] IO cost model based work-conserving porportional controller Tejun Heo
2019-08-28 22:05 ` [PATCH 01/10] blkcg: pass @q and @blkcg into blkcg_pol_alloc_pd_fn() Tejun Heo
2019-08-28 22:05 ` [PATCH 02/10] blkcg: make ->cpd_init_fn() optional Tejun Heo
2019-08-28 22:05 ` [PATCH 03/10] blkcg: separate blkcg_conf_get_disk() out of blkg_conf_prep() Tejun Heo
2019-08-28 22:05 ` [PATCH 04/10] block/rq_qos: add rq_qos_merge() Tejun Heo
2019-08-28 22:05 ` [PATCH 05/10] block/rq_qos: implement rq_qos_ops->queue_depth_changed() Tejun Heo
2019-08-28 22:05 ` [PATCH 06/10] blkcg: s/RQ_QOS_CGROUP/RQ_QOS_LATENCY/ Tejun Heo
2019-08-28 22:05 ` [PATCH 07/10] blk-mq: add optional request->alloc_time_ns Tejun Heo
2019-08-28 22:05 ` [PATCH 08/10] blkcg: implement blk-iocost Tejun Heo
2019-08-29 15:53 ` [PATCH] blkcg: fix missing free on error path of blk_iocost_init() Tejun Heo
2019-09-10 12:55 ` [PATCH 08/10] blkcg: implement blk-iocost Michal Koutný
2019-09-10 16:08 ` Tejun Heo
2019-09-11 8:18 ` Paolo Valente
2019-09-11 14:16 ` Tejun Heo
2019-09-11 15:54 ` Tejun Heo
2019-09-11 16:44 ` Paolo Valente
2019-10-03 14:51 ` Michal Koutný
2019-10-03 16:45 ` Tejun Heo [this message]
2019-10-09 15:36 ` Michal Koutný
2019-10-14 15:36 ` Tejun Heo
2019-11-01 16:15 ` Michal Koutný
2019-11-01 16:56 ` Paolo Valente
2019-08-28 22:05 ` [PATCH 09/10] blkcg: add tools/cgroup/iocost_monitor.py Tejun Heo
2019-08-28 22:06 ` [PATCH 10/10] blkcg: add tools/cgroup/iocost_coef_gen.py Tejun Heo
2019-08-29 3:29 ` [PATCHSET v3 block/for-linus] IO cost model based work-conserving porportional controller Jens Axboe
[not found] ` <20190829082248.6464-1-hdanton@sina.com>
2019-08-29 15:43 ` [PATCH 07/10] blk-mq: add optional request->alloc_time_ns Tejun Heo
[not found] ` <20190829133928.16192-1-hdanton@sina.com>
2019-08-29 15:46 ` [PATCH 08/10] blkcg: implement blk-iocost Tejun Heo
2019-08-29 15:54 ` [PATCHSET v3 block/for-linus] IO cost model based work-conserving porportional controller Paolo Valente
2019-08-29 15:56 ` Tejun Heo
-- strict thread matches above, loose matches on Subject: below --
2019-07-10 20:51 [PATCHSET v2 " Tejun Heo
2019-07-10 20:51 ` [PATCH 08/10] blkcg: implement blk-iocost Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191003164552.GA3247445@devbig004.ftw2.facebook.com \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=clm@fb.com \
--cc=dennisz@fb.com \
--cc=hannes@cmpxchg.org \
--cc=jbacik@fb.com \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=mkoutny@suse.com \
--cc=newella@fb.com \
--cc=paolo.valente@linaro.org \
--cc=riel@surriel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).