From: Keith Busch <kbusch@kernel.org>
To: Tony Asleson <tasleson@redhat.com>
Cc: linux-scsi@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: [RFC PATCH v2 7/7] nvme: Add durable name for dev_printk
Date: Thu, 14 May 2020 08:04:55 +0900 [thread overview]
Message-ID: <20200513230455.GA1503@redsun51.ssa.fujisawa.hgst.com> (raw)
In-Reply-To: <20200513213621.470411-8-tasleson@redhat.com>
On Wed, May 13, 2020 at 04:36:21PM -0500, Tony Asleson wrote:
> +static int dev_to_nvme_durable_name(const struct device *dev, char *buf, size_t len)
> +{
> + char serial[128];
> + ssize_t serial_len = wwid_show((struct device *)dev, NULL, serial);
wwid_show() can generate a serial larger than 128 bytes.
> +
> + if (serial_len > 0 && serial_len < len) {
> + serial_len -= 1; // Remove the '\n' from the string
Comments in this driver should use the /* */ style.
> + strncpy(buf, serial, serial_len);
> + return serial_len;
> + }
> + return 0;
> +}
next prev parent reply other threads:[~2020-05-13 23:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 21:36 [RFC PATCH v2 0/7] Add persistent durable identifier to storage log messages Tony Asleson
2020-05-13 21:36 ` [RFC PATCH v2 1/7] struct device: Add function callback durable_name Tony Asleson
2020-05-13 21:36 ` [RFC PATCH v2 2/7] create_syslog_header: Add durable name Tony Asleson
2020-05-13 21:36 ` [RFC PATCH v2 3/7] print_req_error: Use dev_printk Tony Asleson
2020-05-13 21:36 ` [RFC PATCH v2 4/7] buffer_io_error: " Tony Asleson
2020-05-13 21:36 ` [RFC PATCH v2 5/7] ata_dev_printk: " Tony Asleson
2020-05-14 5:53 ` Hannes Reinecke
2020-05-14 18:03 ` Tony Asleson
[not found] ` <CGME20200626135627eucas1p2d68eb5853f90bc636faab69149fbe02c@eucas1p2.samsung.com>
2020-06-26 13:56 ` Bartlomiej Zolnierkiewicz
2020-05-13 21:36 ` [RFC PATCH v2 6/7] scsi: Add durable_name for dev_printk Tony Asleson
2020-05-13 21:36 ` [RFC PATCH v2 7/7] nvme: Add durable name " Tony Asleson
2020-05-13 23:04 ` Keith Busch [this message]
2020-05-14 17:13 ` Tony Asleson
2020-05-14 17:20 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200513230455.GA1503@redsun51.ssa.fujisawa.hgst.com \
--to=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=tasleson@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).