From: Michal Hocko <mhocko@kernel.org>
To: Naresh Kamboju <naresh.kamboju@linaro.org>
Cc: Chris Down <chris@chrisdown.name>,
Yafang Shao <laoar.shao@gmail.com>,
Anders Roxell <anders.roxell@linaro.org>,
"Linux F2FS DEV,
Mailing List" <linux-f2fs-devel@lists.sourceforge.net>,
linux-ext4 <linux-ext4@vger.kernel.org>,
linux-block <linux-block@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
open list <linux-kernel@vger.kernel.org>,
Linux-Next Mailing List <linux-next@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>, Arnd Bergmann <arnd@arndb.de>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Jaegeuk Kim <jaegeuk@kernel.org>, Theodore Ts'o <tytso@mit.edu>,
Chao Yu <chao@kernel.org>, Hugh Dickins <hughd@google.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Matthew Wilcox <willy@infradead.org>,
Chao Yu <yuchao0@huawei.com>,
lkft-triage@lists.linaro.org,
Johannes Weiner <hannes@cmpxchg.org>,
Roman Gushchin <guro@fb.com>, Cgroups <cgroups@vger.kernel.org>
Subject: Re: mm: mkfs.ext4 invoked oom-killer on i386 - pagecache_get_page
Date: Thu, 21 May 2020 12:58:01 +0200 [thread overview]
Message-ID: <20200521105801.GL6462@dhcp22.suse.cz> (raw)
In-Reply-To: <CA+G9fYvAB9F+Xo0vUsSveKnExkv3cV9-oOG9gBqGEcXsO95m0w@mail.gmail.com>
On Thu 21-05-20 16:11:11, Naresh Kamboju wrote:
> On Thu, 21 May 2020 at 15:25, Michal Hocko <mhocko@kernel.org> wrote:
> >
> > On Wed 20-05-20 20:09:06, Chris Down wrote:
> > > Hi Naresh,
> > >
> > > Naresh Kamboju writes:
> > > > As a part of investigation on this issue LKFT teammate Anders Roxell
> > > > git bisected the problem and found bad commit(s) which caused this problem.
> > > >
> > > > The following two patches have been reverted on next-20200519 and retested the
> > > > reproducible steps and confirmed the test case mkfs -t ext4 got PASS.
> > > > ( invoked oom-killer is gone now)
> > > >
> > > > Revert "mm, memcg: avoid stale protection values when cgroup is above
> > > > protection"
> > > > This reverts commit 23a53e1c02006120f89383270d46cbd040a70bc6.
> > > >
> > > > Revert "mm, memcg: decouple e{low,min} state mutations from protection
> > > > checks"
> > > > This reverts commit 7b88906ab7399b58bb088c28befe50bcce076d82.
> > >
> > > Thanks Anders and Naresh for tracking this down and reverting.
> > >
> > > I'll take a look tomorrow. I don't see anything immediately obviously wrong
> > > in either of those commits from a (very) cursory glance, but they should
> > > only be taking effect if protections are set.
> >
> > Agreed. If memory.{low,min} is not used then the patch should be
> > effectively a nop. Btw. do you see the problem when booting with
> > cgroup_disable=memory kernel command line parameter?
>
> With extra kernel command line parameters, cgroup_disable=memory
> I have noticed a differ problem now.
>
> + mkfs -t ext4 /dev/disk/by-id/ata-TOSHIBA_MG04ACA100N_Y8NRK0BPF6XF
> mke2fs 1.43.8 (1-Jan-2018)
> Creating filesystem with 244190646 4k blocks and 61054976 inodes
> Filesystem UUID: 3bb1a285-2cb4-44b4-b6e8-62548f3ac620
> Superblock backups stored on blocks:
> 32768, 98304, 163840, 229376, 294912, 819200, 884736, 1605632, 2654208,
> 4096000, 7962624, 11239424, 20480000, 23887872, 71663616, 78675968,
> 102400000, 214990848
> Allocating group tables: 0/7453 done
> Writing inode tables: 0/7453 done
> Creating journal (262144 blocks): [ 35.502102] BUG: kernel NULL
> pointer dereference, address: 000000c8
> [ 35.508372] #PF: supervisor read access in kernel mode
> [ 35.513506] #PF: error_code(0x0000) - not-present page
> [ 35.518638] *pde = 00000000
> [ 35.521514] Oops: 0000 [#1] SMP
> [ 35.524652] CPU: 0 PID: 145 Comm: kswapd0 Not tainted
> 5.7.0-rc6-next-20200519+ #1
> [ 35.532121] Hardware name: Supermicro SYS-5019S-ML/X11SSH-F, BIOS
> 2.2 05/23/2018
> [ 35.539507] EIP: mem_cgroup_get_nr_swap_pages+0x28/0x60
Could you get faddr2line for this offset?
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2020-05-21 10:58 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CA+G9fYu2ruH-8uxBHE0pdE6RgRTSx4QuQPAN=Nv3BCdRd2ouYA@mail.gmail.com>
[not found] ` <20200501135806.4eebf0b92f84ab60bba3e1e7@linux-foundation.org>
2020-05-18 14:10 ` mm: mkfs.ext4 invoked oom-killer on i386 - pagecache_get_page Naresh Kamboju
2020-05-19 7:52 ` Michal Hocko
2020-05-19 8:11 ` Arnd Bergmann
2020-05-19 8:45 ` Michal Hocko
2020-05-20 11:56 ` Naresh Kamboju
2020-05-20 17:59 ` Naresh Kamboju
2020-05-20 19:09 ` Chris Down
2020-05-21 9:22 ` Naresh Kamboju
2020-05-21 9:35 ` Arnd Bergmann
2020-05-21 9:55 ` Michal Hocko
2020-05-21 10:41 ` Naresh Kamboju
2020-05-21 10:58 ` Michal Hocko [this message]
2020-05-21 12:24 ` Hugh Dickins
2020-05-21 12:44 ` Michal Hocko
2020-05-21 19:17 ` Johannes Weiner
2020-05-21 20:06 ` Hugh Dickins
2020-05-21 21:58 ` Johannes Weiner
2020-05-21 23:35 ` Hugh Dickins
2020-05-28 14:59 ` Michal Hocko
2020-05-21 16:34 ` Michal Hocko
2020-05-21 19:00 ` Naresh Kamboju
2020-05-21 20:53 ` Naresh Kamboju
2020-05-28 15:03 ` Michal Hocko
2020-05-28 16:17 ` Naresh Kamboju
2020-05-28 16:41 ` Chris Down
2020-05-29 1:50 ` Yafang Shao
2020-05-29 1:56 ` Chris Down
2020-05-29 9:49 ` Michal Hocko
2020-06-11 9:55 ` Michal Hocko
2020-06-12 9:43 ` Naresh Kamboju
2020-06-12 12:09 ` Michal Hocko
2020-06-17 13:37 ` Naresh Kamboju
2020-06-17 13:57 ` Chris Down
2020-06-17 14:11 ` Michal Hocko
2020-06-17 15:53 ` Naresh Kamboju
2020-06-17 16:06 ` Michal Hocko
2020-06-17 20:13 ` Naresh Kamboju
2020-06-17 21:09 ` Chris Down
2020-06-18 1:43 ` Yafang Shao
2020-06-18 12:37 ` Chris Down
2020-06-18 12:41 ` Michal Hocko
2020-06-18 12:49 ` Chris Down
2020-06-18 14:59 ` Yafang Shao
2020-06-17 13:59 ` Michal Hocko
2020-06-17 14:08 ` Chris Down
2020-05-21 2:39 ` Yafang Shao
2020-05-21 8:58 ` Naresh Kamboju
2020-05-21 9:47 ` Yafang Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200521105801.GL6462@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=aarcange@redhat.com \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=anders.roxell@linaro.org \
--cc=arnd@arndb.de \
--cc=cgroups@vger.kernel.org \
--cc=chao@kernel.org \
--cc=chris@chrisdown.name \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=jaegeuk@kernel.org \
--cc=laoar.shao@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-next@vger.kernel.org \
--cc=lkft-triage@lists.linaro.org \
--cc=naresh.kamboju@linaro.org \
--cc=tytso@mit.edu \
--cc=willy@infradead.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).