From: Coly Li <colyli@suse.de>
To: linux-bcache@vger.kernel.org
Cc: linux-block@vger.kernel.org, Coly Li <colyli@suse.de>,
Damien Le Moal <damien.lemoal@wdc.com>,
Hannes Reinecke <hare@suse.com>,
Johannes Thumshirn <johannes.thumshirn@wdc.com>
Subject: [RFC PATCH v4 3/3] bcache: reject writeback cache mode for zoned backing device
Date: Fri, 22 May 2020 20:18:37 +0800 [thread overview]
Message-ID: <20200522121837.109651-4-colyli@suse.de> (raw)
In-Reply-To: <20200522121837.109651-1-colyli@suse.de>
Currently we don't support writeback mode for zoned device as backing
device. So reject it by sysfs interface.
This rejection will be removed after the writeback cache mode support
for zoned device gets done.
Signed-off-by: Coly Li <colyli@suse.de>
Cc: Damien Le Moal <damien.lemoal@wdc.com>
Cc: Hannes Reinecke <hare@suse.com>
Cc: Johannes Thumshirn <johannes.thumshirn@wdc.com>
---
drivers/md/bcache/sysfs.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/md/bcache/sysfs.c b/drivers/md/bcache/sysfs.c
index 323276994aab..41bdbc42a17d 100644
--- a/drivers/md/bcache/sysfs.c
+++ b/drivers/md/bcache/sysfs.c
@@ -359,6 +359,11 @@ STORE(__cached_dev)
if (v < 0)
return v;
+ if ((unsigned int) v == CACHE_MODE_WRITEBACK) {
+ pr_err("writeback mode is not supported for zoned backing device.\n");
+ return -ENOTSUPP;
+ }
+
if ((unsigned int) v != BDEV_CACHE_MODE(&dc->sb)) {
SET_BDEV_CACHE_MODE(&dc->sb, v);
bch_write_bdev_super(dc, NULL);
--
2.25.0
next prev parent reply other threads:[~2020-05-22 12:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 12:18 [RFC PATCH v4 0/3] bcache: support zoned device as bcache backing device Coly Li
2020-05-22 12:18 ` [RFC PATCH v4 1/3] bcache: export bcache zone information for zoned " Coly Li
2020-05-25 1:10 ` Damien Le Moal
2020-06-01 12:34 ` Coly Li
2020-06-02 8:48 ` Damien Le Moal
2020-06-02 12:50 ` Coly Li
2020-06-03 0:58 ` Damien Le Moal
2020-05-22 12:18 ` [RFC PATCH v4 2/3] bcache: handle zone management bios for bcache device Coly Li
2020-05-25 1:24 ` Damien Le Moal
2020-06-01 16:06 ` Coly Li
2020-06-02 8:54 ` Damien Le Moal
2020-06-02 10:18 ` Coly Li
2020-06-03 0:51 ` Damien Le Moal
2020-05-22 12:18 ` Coly Li [this message]
2020-05-25 1:26 ` [RFC PATCH v4 3/3] bcache: reject writeback cache mode for zoned backing device Damien Le Moal
2020-06-01 16:09 ` Coly Li
2020-05-25 5:25 ` [RFC PATCH v4 0/3] bcache: support zoned device as bcache " Damien Le Moal
2020-05-25 8:14 ` Coly Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200522121837.109651-4-colyli@suse.de \
--to=colyli@suse.de \
--cc=damien.lemoal@wdc.com \
--cc=hare@suse.com \
--cc=johannes.thumshirn@wdc.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).