From: Matthew Wilcox <willy@infradead.org>
To: Mike Snitzer <snitzer@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
linux-raid@vger.kernel.org, linux-mm@kvack.org,
linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-block@vger.kernel.org, drbd-dev@tron.linbit.com,
dm-devel@redhat.com, Tejun Heo <tj@kernel.org>,
cgroups@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: remove dead bdi congestion leftovers
Date: Wed, 1 Jul 2020 19:25:38 +0100 [thread overview]
Message-ID: <20200701182538.GU25523@casper.infradead.org> (raw)
In-Reply-To: <20200701175747.GT25523@casper.infradead.org>
On Wed, Jul 01, 2020 at 06:57:47PM +0100, Matthew Wilcox wrote:
> On Wed, Jul 01, 2020 at 12:41:03PM -0400, Mike Snitzer wrote:
> > On Wed, Jul 01 2020 at 5:06am -0400,
> > Christoph Hellwig <hch@lst.de> wrote:
> >
> > > Hi Jens,
> > >
> > > we have a lot of bdi congestion related code that is left around without
> > > any use. This series removes it in preparation of sorting out the bdi
> > > lifetime rules properly.
> >
> > I could do some git archeology to see what the fs, mm and block core
> > changes were to stop using bdi congested but a pointer to associated
> > changes (or quick recap) would save me some time.
> >
> > Also, curious to know how back-pressure should be felt back up the IO
> > stack now? (apologies if these are well worn topics, I haven't been
> > tracking this area of development).
>
> It isn't. Jens declared the implementation was broken, and broke it
> more. So we're just living with stupid broken timeouts.
Here's a thread about it. This would have been a discussion topic at
LSFMM2020, but COVID.
https://lore.kernel.org/linux-mm/20190917115824.16990-1-linf@wangsu.com/T/#u
next prev parent reply other threads:[~2020-07-01 18:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 9:06 remove dead bdi congestion leftovers Christoph Hellwig
2020-07-01 9:06 ` [PATCH 1/4] drbd: remove a bogus bdi_rw_congested call Christoph Hellwig
2020-07-01 9:06 ` [PATCH 2/4] writeback: remove {set,clear}_wb_congested Christoph Hellwig
2020-07-01 9:06 ` [PATCH 3/4] writeback: remove struct bdi_writeback_congested Christoph Hellwig
2020-07-01 9:06 ` [PATCH 4/4] writeback: remove bdi->congested_fn Christoph Hellwig
2020-07-01 14:48 ` David Sterba
2020-07-02 0:38 ` Coly Li
2020-07-02 5:36 ` Song Liu
2020-07-01 16:38 ` remove dead bdi congestion leftovers Tejun Heo
2020-07-01 16:41 ` Mike Snitzer
2020-07-01 17:57 ` Matthew Wilcox
2020-07-01 18:25 ` Matthew Wilcox [this message]
2020-07-08 23:14 ` Jens Axboe
2020-07-09 5:32 ` Christoph Hellwig
2020-07-09 13:58 ` Jens Axboe
2020-07-09 14:01 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200701182538.GU25523@casper.infradead.org \
--to=willy@infradead.org \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=dm-devel@redhat.com \
--cc=drbd-dev@tron.linbit.com \
--cc=hch@lst.de \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-raid@vger.kernel.org \
--cc=snitzer@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).