From: Jan Kara <jack@suse.cz>
To: "zhangyi (F)" <yi.zhang@huawei.com>
Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-block@vger.kernel.org, jack@suse.cz, tytso@mit.edu,
viro@zeniv.linux.org.uk, hch@infradead.org, axboe@kernel.dk,
mcgrof@kernel.org, keescook@chromium.org, yzaikin@google.com
Subject: Re: [RFC PATCH 3/3] block_dump: remove comments in docs
Date: Mon, 15 Mar 2021 10:48:17 +0100 [thread overview]
Message-ID: <20210315094817.GC3227@quack2.suse.cz> (raw)
In-Reply-To: <20210313030146.2882027-4-yi.zhang@huawei.com>
On Sat 13-03-21 11:01:46, zhangyi (F) wrote:
> Now block_dump feature is gone, remove all comments in docs.
>
> Signed-off-by: zhangyi (F) <yi.zhang@huawei.com>
Nice. Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> Documentation/admin-guide/laptops/laptop-mode.rst | 11 -----------
> Documentation/admin-guide/sysctl/vm.rst | 8 --------
> 2 files changed, 19 deletions(-)
>
> diff --git a/Documentation/admin-guide/laptops/laptop-mode.rst b/Documentation/admin-guide/laptops/laptop-mode.rst
> index c984c4262f2e..b61cc601d298 100644
> --- a/Documentation/admin-guide/laptops/laptop-mode.rst
> +++ b/Documentation/admin-guide/laptops/laptop-mode.rst
> @@ -101,17 +101,6 @@ this results in concentration of disk activity in a small time interval which
> occurs only once every 10 minutes, or whenever the disk is forced to spin up by
> a cache miss. The disk can then be spun down in the periods of inactivity.
>
> -If you want to find out which process caused the disk to spin up, you can
> -gather information by setting the flag /proc/sys/vm/block_dump. When this flag
> -is set, Linux reports all disk read and write operations that take place, and
> -all block dirtyings done to files. This makes it possible to debug why a disk
> -needs to spin up, and to increase battery life even more. The output of
> -block_dump is written to the kernel output, and it can be retrieved using
> -"dmesg". When you use block_dump and your kernel logging level also includes
> -kernel debugging messages, you probably want to turn off klogd, otherwise
> -the output of block_dump will be logged, causing disk activity that is not
> -normally there.
> -
>
> Configuration
> -------------
> diff --git a/Documentation/admin-guide/sysctl/vm.rst b/Documentation/admin-guide/sysctl/vm.rst
> index 586cd4b86428..3ca6679f16ea 100644
> --- a/Documentation/admin-guide/sysctl/vm.rst
> +++ b/Documentation/admin-guide/sysctl/vm.rst
> @@ -25,7 +25,6 @@ files can be found in mm/swap.c.
> Currently, these files are in /proc/sys/vm:
>
> - admin_reserve_kbytes
> -- block_dump
> - compact_memory
> - compaction_proactiveness
> - compact_unevictable_allowed
> @@ -106,13 +105,6 @@ On x86_64 this is about 128MB.
> Changing this takes effect whenever an application requests memory.
>
>
> -block_dump
> -==========
> -
> -block_dump enables block I/O debugging when set to a nonzero value. More
> -information on block I/O debugging is in Documentation/admin-guide/laptops/laptop-mode.rst.
> -
> -
> compact_memory
> ==============
>
> --
> 2.25.4
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2021-03-15 9:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-13 3:01 [RFC PATCH 0/3] block_dump: remove block dump zhangyi (F)
2021-03-13 3:01 ` [RFC PATCH 1/3] block_dump: remove block_dump feature in mark_inode_dirty() zhangyi (F)
2021-03-15 9:47 ` Jan Kara
2021-03-13 3:01 ` [RFC PATCH 2/3] block_dump: remove block_dump feature zhangyi (F)
2021-03-15 9:48 ` Jan Kara
2021-03-13 3:01 ` [RFC PATCH 3/3] block_dump: remove comments in docs zhangyi (F)
2021-03-15 9:48 ` Jan Kara [this message]
2021-03-13 3:37 ` [RFC PATCH 0/3] block_dump: remove block dump Jens Axboe
2021-05-10 1:29 ` Zhang Yi
2021-03-15 9:56 ` Christoph Hellwig
2021-05-10 15:21 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210315094817.GC3227@quack2.suse.cz \
--to=jack@suse.cz \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=keescook@chromium.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=yi.zhang@huawei.com \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).