From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
linux-block@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
John Garry <john.garry@huawei.com>,
Sagi Grimberg <sagi@grimberg.me>, Daniel Wagner <dwagner@suse.de>,
Wen Xiong <wenxiong@us.ibm.com>, Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH V5 1/3] driver core: add device_has_managed_msi_irq
Date: Wed, 21 Jul 2021 16:36:15 +0200 [thread overview]
Message-ID: <20210721143615.GA11058@lst.de> (raw)
In-Reply-To: <20210721091723.1152456-2-ming.lei@redhat.com>
On Wed, Jul 21, 2021 at 05:17:21PM +0800, Ming Lei wrote:
> +bool device_has_managed_msi_irq(struct device *dev)
> +{
> + struct msi_desc *desc;
> +
> + if (IS_ENABLED(CONFIG_GENERIC_MSI_IRQ)) {
And inline stub for the !CONFIG_GENERIC_MSI_IRQ would seem nicer
so that we don't even nee the call.
Also please add a kerneldoc comment, and as Greg said this probably
doesn't belong into drivers/base and device.h but something in the
irq layer. Maybe Thomas has a preference.
next prev parent reply other threads:[~2021-07-21 14:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-21 9:17 [PATCH V5 0/3] blk-mq: fix blk_mq_alloc_request_hctx Ming Lei
2021-07-21 9:17 ` [PATCH V5 1/3] driver core: add device_has_managed_msi_irq Ming Lei
2021-07-21 13:48 ` Greg Kroah-Hartman
2021-07-21 14:36 ` Christoph Hellwig [this message]
2021-07-21 9:17 ` [PATCH V5 2/3] blk-mq: mark if one queue map uses managed irq Ming Lei
2021-07-21 14:37 ` Christoph Hellwig
2021-07-22 1:24 ` Ming Lei
2021-07-21 18:53 ` John Garry
2021-07-22 1:22 ` Ming Lei
2021-07-21 9:17 ` [PATCH V5 3/3] blk-mq: don't deactivate hctx if managed irq isn't used Ming Lei
2021-07-21 14:37 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210721143615.GA11058@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=dwagner@suse.de \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.de \
--cc=john.garry@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=sagi@grimberg.me \
--cc=tglx@linutronix.de \
--cc=wenxiong@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).