From: Xie Yongji <xieyongji@bytedance.com>
To: axboe@kernel.dk, hch@lst.de, josef@toxicpanda.com,
mst@redhat.com, jasowang@redhat.com, stefanha@redhat.com,
kwolf@redhat.com
Cc: linux-block@vger.kernel.org, nbd@other.debian.org,
virtualization@lists.linux-foundation.org
Subject: [PATCH v2 2/4] nbd: Use blk_validate_block_size() to validate block size
Date: Mon, 25 Oct 2021 22:25:04 +0800 [thread overview]
Message-ID: <20211025142506.167-3-xieyongji@bytedance.com> (raw)
In-Reply-To: <20211025142506.167-1-xieyongji@bytedance.com>
Use the block layer helper to validate block size instead
of open coding it.
Signed-off-by: Xie Yongji <xieyongji@bytedance.com>
---
drivers/block/nbd.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index 1183f7872b71..3f58c3eb38b6 100644
--- a/drivers/block/nbd.c
+++ b/drivers/block/nbd.c
@@ -323,7 +323,8 @@ static int nbd_set_size(struct nbd_device *nbd, loff_t bytesize,
{
if (!blksize)
blksize = 1u << NBD_DEF_BLKSIZE_BITS;
- if (blksize < 512 || blksize > PAGE_SIZE || !is_power_of_2(blksize))
+
+ if (blk_validate_block_size(blksize))
return -EINVAL;
nbd->config->bytesize = bytesize;
--
2.11.0
next prev parent reply other threads:[~2021-10-25 14:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-25 14:25 [PATCH v2 0/4] Add blk_validate_block_size() helper for drivers to validate block size Xie Yongji
2021-10-25 14:25 ` [PATCH v2 1/4] block: Add a helper to validate the " Xie Yongji
2021-10-25 14:25 ` Xie Yongji [this message]
2021-10-25 14:25 ` [PATCH v2 3/4] loop: Use blk_validate_block_size() to validate " Xie Yongji
2021-10-25 14:25 ` [PATCH v2 4/4] virtio-blk: " Xie Yongji
2021-10-25 17:08 ` Michael S. Tsirkin
2021-10-26 14:32 ` Yongji Xie
2021-10-25 17:01 ` [PATCH v2 0/4] Add blk_validate_block_size() helper for drivers " Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211025142506.167-3-xieyongji@bytedance.com \
--to=xieyongji@bytedance.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=jasowang@redhat.com \
--cc=josef@toxicpanda.com \
--cc=kwolf@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=mst@redhat.com \
--cc=nbd@other.debian.org \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).