From: Jens Axboe <axboe@kernel.dk>
To: Ming Lei <ming.lei@redhat.com>
Cc: linux-block@vger.kernel.org, Bart Van Assche <bvanassche@acm.org>,
Christoph Hellwig <hch@lst.de>, Yi Zhang <yi.zhang@redhat.com>,
syzbot+b9d0d56867048c7bcfde@syzkaller.appspotmail.com
Subject: Re: [PATCH] blk-mq: remove WARN_ON(!q->elevator) from blk_mq_sched_free_requests
Date: Thu, 13 Jun 2019 03:06:11 -0600 [thread overview]
Message-ID: <29bc5206-7598-c65d-bef0-d8ec34c0934d@kernel.dk> (raw)
In-Reply-To: <20190611093153.7147-1-ming.lei@redhat.com>
On 6/11/19 3:31 AM, Ming Lei wrote:
> blk_mq_sched_free_requests() may be called in failure path in which
> q->elevator may not be setup yet, so remove WARN_ON(!q->elevator) from
> blk_mq_sched_free_requests for avoiding the false positive.
>
> This function is actually safe to call in case of !q->elevator because
> hctx->sched_tags is checked.
Applied, thanks Ming.
--
Jens Axboe
prev parent reply other threads:[~2019-06-13 15:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 9:31 [PATCH] blk-mq: remove WARN_ON(!q->elevator) from blk_mq_sched_free_requests Ming Lei
2019-06-13 9:06 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29bc5206-7598-c65d-bef0-d8ec34c0934d@kernel.dk \
--to=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=syzbot+b9d0d56867048c7bcfde@syzkaller.appspotmail.com \
--cc=yi.zhang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).