Re: [PATCH 01/18] lightnvm: pblk: fix warning in pblk_l2p_init()

From: "Javier González" <javier@javigon.com>
To: "Konopko, Igor J" <igor.j.konopko@intel.com>
Cc: "Matias Bjørling" <mb@lightnvm.io>,
	"Hans Holmberg" <hans.holmberg@cnexlabs.com>,
	linux-block@vger.kernel.org
Subject: Re: [PATCH 01/18] lightnvm: pblk: fix warning in pblk_l2p_init()
Date: Sat, 16 Mar 2019 15:29:21 -0700	[thread overview]
Message-ID: <47F1D515-DE64-443A-9569-DBA611D21066@javigon.com> (raw)
In-Reply-To: <20190314160428.3559-2-igor.j.konopko@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1079 bytes --]

> On 14 Mar 2019, at 09.04, Igor Konopko <igor.j.konopko@intel.com> wrote:
> 
> This patch fixes a compilation warning caused by improper format
> specifier provided in pblk_l2p_init().
> 
> Fixes: fe0c220 ("lightnvm: pblk: cleanly fail when there is not enough memory")
> Signed-off-by: Igor Konopko <igor.j.konopko@intel.com>
> ---
> drivers/lightnvm/pblk-init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/lightnvm/pblk-init.c b/drivers/lightnvm/pblk-init.c
> index 1940f89..1e227a0 100644
> --- a/drivers/lightnvm/pblk-init.c
> +++ b/drivers/lightnvm/pblk-init.c
> @@ -159,7 +159,7 @@ static int pblk_l2p_init(struct pblk *pblk, bool factory_init)
> 					| __GFP_RETRY_MAYFAIL | __GFP_HIGHMEM,
> 					PAGE_KERNEL);
> 	if (!pblk->trans_map) {
> -		pblk_err(pblk, "failed to allocate L2P (need %ld of memory)\n",
> +		pblk_err(pblk, "failed to allocate L2P (need %zu of memory)\n",
> 				map_size);
> 		return -ENOMEM;
> 	}
> --
> 2.9.5

Looks food to me.

Reviewed-by: Javier González <javier@javigon.com>

[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 833 bytes --]