From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@lst.de>
Cc: sandeen@sandeen.net, linux-block@vger.kernel.org,
"Michal Koutný" <mkoutny@suse.com>,
"Yang Xu" <xuyang2018.jy@cn.fujitsu.com>
Subject: Re: [PATCH] block: remove the bd_openers checks in blk_drop_partitions
Date: Thu, 30 Apr 2020 10:26:09 -0600 [thread overview]
Message-ID: <5452acd0-96d0-e3ec-f0e4-a322d540dc0e@kernel.dk> (raw)
In-Reply-To: <20200428085203.1852494-1-hch@lst.de>
On 4/28/20 2:52 AM, Christoph Hellwig wrote:
> When replacing the bd_super check with a bd_openers I followed a logical
> conclusion, which turns out to be utterly wrong. When a block device has
> bd_super sets it has a mount file system on it (although not every
> mounted file system sets bd_super), but that also implies it doesn't even
> have partitions to start with.
>
> So instead of trying to come up with a logical check for all openers,
> just remove the check entirely.
Applied, thanks.
--
Jens Axboe
prev parent reply other threads:[~2020-04-30 16:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-28 8:52 [PATCH] block: remove the bd_openers checks in blk_drop_partitions Christoph Hellwig
2020-04-28 10:20 ` Michal Koutný
2020-04-30 16:01 ` Christoph Hellwig
2020-04-30 16:26 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5452acd0-96d0-e3ec-f0e4-a322d540dc0e@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=mkoutny@suse.com \
--cc=sandeen@sandeen.net \
--cc=xuyang2018.jy@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).