From: Hannes Reinecke <hare@suse.de>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Khalid Aziz <khalid@gonehiking.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Matthew Wilcox <willy@infradead.org>,
Hannes Reinecke <hare@suse.com>,
Ondrej Zary <linux@rainbow-software.org>
Cc: linux-block@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 1/8] aha1542: use a local bounce buffer
Date: Mon, 29 Mar 2021 08:22:00 +0200 [thread overview]
Message-ID: <658eb950-d675-77c6-c3b6-fb9c23aff716@suse.de> (raw)
In-Reply-To: <20210326055822.1437471-2-hch@lst.de>
On 3/26/21 6:58 AM, Christoph Hellwig wrote:
> To remove the last user of the unchecked_isa_dma flag and thus the block
> layer ISA bounce buffering switch this driver to use its own local bounce
> buffer. This has the effect of not needing the chain indirection and
> supporting and unlimited number of segments. It does however limit the
> transfer size for each command to something that can be reasonable
> allocated by dma_alloc_coherent like 8K.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> drivers/scsi/aha1542.c | 105 ++++++++++++++++++++++-------------------
> 1 file changed, 57 insertions(+), 48 deletions(-)
>
I doubt anyone will notice the reduced transfer size; these things are
slow anyway :-)
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer
next prev parent reply other threads:[~2021-03-29 6:23 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 5:58 start removing block bounce buffering support v2 Christoph Hellwig
2021-03-26 5:58 ` [PATCH 1/8] aha1542: use a local bounce buffer Christoph Hellwig
2021-03-29 6:22 ` Hannes Reinecke [this message]
2021-03-26 5:58 ` [PATCH 2/8] Buslogic: remove ISA support Christoph Hellwig
2021-03-29 6:22 ` Hannes Reinecke
2021-03-29 20:29 ` Khalid Aziz
2021-03-30 17:03 ` Christoph Hellwig
2021-03-30 17:15 ` Khalid Aziz
2021-03-30 17:31 ` Christoph Hellwig
2021-03-26 5:58 ` [PATCH 3/8] BusLogic: reject broken old firmware that requires ISA-style bounce buffering Christoph Hellwig
2021-03-29 6:23 ` Hannes Reinecke
2021-03-29 20:33 ` Khalid Aziz
2021-03-26 5:58 ` [PATCH 4/8] advansys: remove ISA support Christoph Hellwig
2021-03-29 6:31 ` Hannes Reinecke
2021-03-30 17:26 ` Christoph Hellwig
2021-03-26 5:58 ` [PATCH 5/8] scsi: remove the unchecked_isa_dma flag Christoph Hellwig
2021-03-29 6:31 ` Hannes Reinecke
2021-03-26 5:58 ` [PATCH 6/8] block: remove BLK_BOUNCE_ISA support Christoph Hellwig
2021-03-29 6:32 ` Hannes Reinecke
2021-03-26 5:58 ` [PATCH 7/8] block: refactor the bounce buffering code Christoph Hellwig
2021-03-29 6:34 ` Hannes Reinecke
2021-03-26 5:58 ` [PATCH 8/8] block: stop calling blk_queue_bounce for passthrough requests Christoph Hellwig
2021-03-29 6:37 ` Hannes Reinecke
2021-03-26 23:15 ` start removing block bounce buffering support v2 Jens Axboe
2021-03-30 3:08 ` Martin K. Petersen
-- strict thread matches above, loose matches on Subject: below --
2021-03-31 7:29 start removing block bounce buffering support v3 Christoph Hellwig
2021-03-31 7:29 ` [PATCH 1/8] aha1542: use a local bounce buffer Christoph Hellwig
2021-03-18 6:39 start removing block bounce buffering support Christoph Hellwig
2021-03-18 6:39 ` [PATCH 1/8] aha1542: use a local bounce buffer Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=658eb950-d675-77c6-c3b6-fb9c23aff716@suse.de \
--to=hare@suse.de \
--cc=axboe@kernel.dk \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=khalid@gonehiking.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@rainbow-software.org \
--cc=martin.petersen@oracle.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).