From: Varad Gautam <varad.gautam@suse.com>
To: Ming Lei <ming.lei@redhat.com>, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>,
linux-block@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>
Cc: John Garry <john.garry@huawei.com>,
Sagi Grimberg <sagi@grimberg.me>, Daniel Wagner <dwagner@suse.de>,
Wen Xiong <wenxiong@us.ibm.com>
Subject: Re: [PATCH V7 1/3] genirq: add device_has_managed_msi_irq
Date: Mon, 11 Oct 2021 20:23:09 +0200 [thread overview]
Message-ID: <6da6924e-88ab-b1e4-e3bf-6f8d3967b690@suse.com> (raw)
In-Reply-To: <20210818144428.896216-2-ming.lei@redhat.com>
Hi Ming,
On 8/18/21 4:44 PM, Ming Lei wrote:
> irq vector allocation with managed affinity may be used by driver, and
> blk-mq needs this info for draining queue because genirq core will shutdown
> managed irq when all CPUs in the affinity mask are offline.
>
> The info of using managed irq is often produced by drivers, and it is
> consumed by blk-mq, so different subsystems are involved in this info flow.
>
> Address this issue by adding one helper of device_has_managed_msi_irq()
> which is suggested by John Garry.
>
> Tested-by: Wen Xiong <wenxiong@us.ibm.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Suggested-by: John Garry <john.garry@huawei.com>
> Signed-off-by: Ming Lei <ming.lei@redhat.com>
> ---
> include/linux/msi.h | 5 +++++
> kernel/irq/msi.c | 18 ++++++++++++++++++
> 2 files changed, 23 insertions(+)
>
> diff --git a/include/linux/msi.h b/include/linux/msi.h
> index a20dc66b9946..b4511c606072 100644
> --- a/include/linux/msi.h
> +++ b/include/linux/msi.h
> @@ -59,10 +59,15 @@ struct platform_msi_priv_data;
> void __get_cached_msi_msg(struct msi_desc *entry, struct msi_msg *msg);
> #ifdef CONFIG_GENERIC_MSI_IRQ
> void get_cached_msi_msg(unsigned int irq, struct msi_msg *msg);
> +bool device_has_managed_msi_irq(struct device *dev);
This led me to the following build warning:
In file included from ../drivers/iommu/irq_remapping.c:6:0:
../include/linux/msi.h:23:40: warning: 'struct device' declared inside parameter list will not be visible outside of this definition or declaration
A forward declaration for struct device before the #ifdef
would fix this.
Regards,
Varad
> #else
> static inline void get_cached_msi_msg(unsigned int irq, struct msi_msg *msg)
> {
> }
> +static inline bool device_has_managed_msi_irq(struct device *dev)
> +{
> + return false;
> +}
> #endif
>
> typedef void (*irq_write_msi_msg_t)(struct msi_desc *desc,
> diff --git a/kernel/irq/msi.c b/kernel/irq/msi.c
> index 00f89d5bd6f6..167bc1d8bf4a 100644
> --- a/kernel/irq/msi.c
> +++ b/kernel/irq/msi.c
> @@ -71,6 +71,24 @@ void get_cached_msi_msg(unsigned int irq, struct msi_msg *msg)
> }
> EXPORT_SYMBOL_GPL(get_cached_msi_msg);
>
> +/**
> + * device_has_managed_msi_irq - Query if device has managed irq entry
> + * @dev: Pointer to the device for which we want to query
> + *
> + * Return true if there is managed irq vector allocated on this device
> + */
> +bool device_has_managed_msi_irq(struct device *dev)
> +{
> + struct msi_desc *desc;
> +
> + for_each_msi_entry(desc, dev) {
> + if (desc->affinity && desc->affinity->is_managed)
> + return true;
> + }
> + return false;
> +}
> +EXPORT_SYMBOL_GPL(device_has_managed_msi_irq);
> +
> #ifdef CONFIG_GENERIC_MSI_IRQ_DOMAIN
> static inline void irq_chip_write_msi_msg(struct irq_data *data,
> struct msi_msg *msg)
>
next prev parent reply other threads:[~2021-10-11 18:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 14:44 [PATCH V7 0/3] blk-mq: fix blk_mq_alloc_request_hctx Ming Lei
2021-08-18 14:44 ` [PATCH V7 1/3] genirq: add device_has_managed_msi_irq Ming Lei
2021-10-11 18:23 ` Varad Gautam [this message]
2021-08-18 14:44 ` [PATCH V7 2/3] blk-mq: mark if one queue map uses managed irq Ming Lei
2021-08-23 17:17 ` Sagi Grimberg
2021-08-18 14:44 ` [PATCH V7 3/3] blk-mq: don't deactivate hctx if managed irq isn't used Ming Lei
2021-08-23 17:18 ` Sagi Grimberg
2021-09-15 16:14 ` Daniel Wagner
2021-09-16 2:17 ` Ming Lei
2021-09-16 7:42 ` Daniel Wagner
2021-09-16 8:13 ` Ming Lei
2021-10-04 12:25 ` [RFC] nvme-fc: Allow managed IRQs Daniel Wagner
2021-08-19 22:38 ` [PATCH V7 0/3] blk-mq: fix blk_mq_alloc_request_hctx Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6da6924e-88ab-b1e4-e3bf-6f8d3967b690@suse.com \
--to=varad.gautam@suse.com \
--cc=axboe@kernel.dk \
--cc=dwagner@suse.de \
--cc=hch@lst.de \
--cc=john.garry@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=sagi@grimberg.me \
--cc=tglx@linutronix.de \
--cc=wenxiong@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).