From: Tony Asleson <tasleson@redhat.com>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: linux-scsi@vger.kernel.org, linux-block@vger.kernel.org,
linux-ide@vger.kernel.org
Subject: Re: [RFC PATCH v3 5/8] ata_dev_printk: Use dev_printk
Date: Fri, 26 Jun 2020 08:54:11 -0500 [thread overview]
Message-ID: <780b9a02-eca6-6e53-638a-a9638425a863@redhat.com> (raw)
In-Reply-To: <9e45d126-f1ac-48b9-56c3-ec0686e38503@samsung.com>
On 6/26/20 7:45 AM, Bartlomiej Zolnierkiewicz wrote:
> Of course I agree that having a persistent identifier associated to
> storage related log messages is useful and my previous mail was exactly
> a part of discussion on the best way to achieving it. :-)
>
> I agree with James that dev_printk() usage is preferred over legacy
> printk_emit() and I've described a way to do it correctly for libata.
>
> Unfortunately it means additional work for getting the new feature
> merged so if you don't agree with doing it you need to convince:
>
> - Jens (libata Maintainer) to accept libata patch as it is
>
> or
>
> - James (& other higher level Maintainers) to use printk_emit() instead
>
> Ultimately they will be the ones merging/long-term supporting proposed
> patches and not me..
Thank you for the helpful response, I appreciate it. I'll take a look
at the information you've provided and re-work the patch series. I may
have additional question(s) :-)
-Tony
next prev parent reply other threads:[~2020-06-26 13:54 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-23 19:17 [RFC PATCH v3 0/8] Add persistent durable identifier to storage log messages Tony Asleson
2020-06-23 19:17 ` [RFC PATCH v3 1/8] struct device: Add function callback durable_name Tony Asleson
2020-06-23 19:17 ` [RFC PATCH v3 2/8] create_syslog_header: Add durable name Tony Asleson
2020-06-23 19:17 ` [RFC PATCH v3 3/8] print_req_error: Use dev_printk Tony Asleson
2020-06-23 19:17 ` [RFC PATCH v3 4/8] buffer_io_error: " Tony Asleson
2020-06-23 19:17 ` [RFC PATCH v3 5/8] ata_dev_printk: " Tony Asleson
[not found] ` <CGME20200624103532eucas1p2c0988207e4dfc2f992d309b75deac3ee@eucas1p2.samsung.com>
2020-06-24 10:35 ` Bartlomiej Zolnierkiewicz
2020-06-24 15:15 ` Tony Asleson
2020-06-26 12:45 ` Bartlomiej Zolnierkiewicz
2020-06-26 13:54 ` Tony Asleson [this message]
[not found] ` <7ed08b94-755f-baab-0555-b4e454405729@redhat.com>
2020-07-14 8:06 ` Bartlomiej Zolnierkiewicz
2020-07-14 8:17 ` Greg Kroah-Hartman
2020-07-14 8:50 ` Bartlomiej Zolnierkiewicz
2020-07-17 10:06 ` Greg Kroah-Hartman
2020-07-17 10:17 ` Hannes Reinecke
2020-07-17 10:27 ` Bartlomiej Zolnierkiewicz
2020-07-17 19:47 ` Tony Asleson
2020-07-24 8:50 ` Bartlomiej Zolnierkiewicz
2020-06-23 19:17 ` [RFC PATCH v3 6/8] scsi: Add durable_name for dev_printk Tony Asleson
2020-06-23 19:17 ` [RFC PATCH v3 7/8] nvme: Add durable name " Tony Asleson
2020-06-23 20:04 ` Chaitanya Kulkarni
2020-06-23 20:32 ` Tony Asleson
2020-06-23 19:17 ` [RFC PATCH v3 8/8] dev_vprintk_emit: Increase hdr size Tony Asleson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=780b9a02-eca6-6e53-638a-a9638425a863@redhat.com \
--to=tasleson@redhat.com \
--cc=b.zolnierkie@samsung.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).