linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Daniel Wagner <dwagner@suse.de>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: Remove callback typedefs for blk_mq_ops
Date: Tue, 28 Jul 2020 10:13:06 -0600	[thread overview]
Message-ID: <7a26c550-934b-a188-b910-3d21d006df41@kernel.dk> (raw)
In-Reply-To: <20200728160506.92926-1-dwagner@suse.de>

On 7/28/20 10:05 AM, Daniel Wagner wrote:
> No need to define typedefs for the callbacks, because there is not a
> single user except blk_mq_ops.

Concept looks fine to me, but you're mixing indentations a bit. Just
remove the indentation bits, we don't need them here.

-- 
Jens Axboe


  reply	other threads:[~2020-07-28 16:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-28 16:05 [PATCH] block: Remove callback typedefs for blk_mq_ops Daniel Wagner
2020-07-28 16:13 ` Jens Axboe [this message]
2020-07-28 16:15   ` Daniel Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7a26c550-934b-a188-b910-3d21d006df41@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=dwagner@suse.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).