linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Rajashekar, Revanth" <revanth.rajashekar@intel.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-block@vger.kernel.org,
	Jonathan Derrick <jonathan.derrick@intel.com>,
	Scott Bauer <sbauer@plzdonthack.me>,
	Jonas Rabenstine <jonas.rabenstein@studium.uni-erlangen.de>,
	David Kozub <zub@linux.fjfi.cvut.cz>,
	Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH v2 2/3] block: sed-opal: Generalizing write data to any opal table
Date: Wed, 16 Oct 2019 10:00:25 -0600	[thread overview]
Message-ID: <7ac5ac89-3544-2a99-dbdb-95d14fbbdeb1@intel.com> (raw)
In-Reply-To: <20191016063212.GB6852@infradead.org>


On 10/16/2019 12:32 AM, Christoph Hellwig wrote:
> On Tue, Oct 15, 2019 at 05:02:45PM -0600, Revanth Rajashekar wrote:
>> +static int generic_table_write_data(struct opal_dev *dev, const u64 data, u64 offset,
> Please at least fix your basic coding style issues before the next
> resend.
Sure :)

  reply	other threads:[~2019-10-16 16:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-15 23:02 [PATCH v2 0/3] block: sed-opal: Generic Read/Write Opal Tables Revanth Rajashekar
2019-10-15 23:02 ` [PATCH v2 1/3] block: sed-opal: Expose enum opal_uid and opaluid Revanth Rajashekar
2019-10-16  6:31   ` Christoph Hellwig
2019-10-16 15:59     ` Rajashekar, Revanth
2019-10-15 23:02 ` [PATCH v2 2/3] block: sed-opal: Generalizing write data to any opal table Revanth Rajashekar
2019-10-16  6:32   ` Christoph Hellwig
2019-10-16 16:00     ` Rajashekar, Revanth [this message]
2019-10-15 23:02 ` [PATCH v2 3/3] block: sed-opal: Add support to read/write opal tables generically Revanth Rajashekar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7ac5ac89-3544-2a99-dbdb-95d14fbbdeb1@intel.com \
    --to=revanth.rajashekar@intel.com \
    --cc=axboe@kernel.dk \
    --cc=hch@infradead.org \
    --cc=jonas.rabenstein@studium.uni-erlangen.de \
    --cc=jonathan.derrick@intel.com \
    --cc=linux-block@vger.kernel.org \
    --cc=sbauer@plzdonthack.me \
    --cc=zub@linux.fjfi.cvut.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).