linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ritika Srivastava <RITIKA.SRIVASTAVA@ORACLE.COM>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-block@vger.kernel.org, axboe@kernel.dk
Subject: Re: [PATCH 1/1] block: return BLK_STS_NOTSUPP if operation is not supported
Date: Tue, 28 Jul 2020 10:18:22 -0700	[thread overview]
Message-ID: <91295B21-661A-416A-A601-AE1671365F72@ORACLE.COM> (raw)
In-Reply-To: <20200728072855.GA4774@infradead.org>



> On Jul 28, 2020, at 12:28 AM, Christoph Hellwig <hch@infradead.org> wrote:
> 
> On Mon, Jul 27, 2020 at 12:11:19PM -0700, Ritika Srivastava wrote:
>> Hence block layer issues write zeroes in blkdev_issue_zeroout()
>> 
>> In response, the storage returns the following SCSI error
>> Sense Key : Illegal Request [current]
>> Add. Sense: Invalid command operation code
>> 
>> Once this error is received, the write zero capability of the device is disabled and write_zeroes_max_bytes is set to 0.
>> DM device queue limits are also set to 0 and device-mapper fails the path.
>> To avoid this, if BLK_STS_NOTSUPP could be returned, then device-mapper would not fail the paths.
>> 
>> Once the write zero capability has been disabled, blk-lib issues zeroes via __blkdev_issue_zero_pages().
>> 
>> Please let me know if I missed something.
> 
> Oh, the stupid SCSI runtime detection case again.  Can you please
> document this in a comment?
> 
> Also please switch blk_cloned_rq_check_limits to just return the
> blk_status_t directly.

Sure, I will make these changes and send updated version.

Thanks,
Ritika


      reply	other threads:[~2020-07-28 17:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-24 16:33 [PATCH 1/1] block: return BLK_STS_NOTSUPP if operation is not supported Ritika Srivastava
2020-07-26 15:10 ` Christoph Hellwig
2020-07-27 19:11   ` Ritika Srivastava
2020-07-28  7:28     ` Christoph Hellwig
2020-07-28 17:18       ` Ritika Srivastava [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=91295B21-661A-416A-A601-AE1671365F72@ORACLE.COM \
    --to=ritika.srivastava@oracle.com \
    --cc=axboe@kernel.dk \
    --cc=hch@infradead.org \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).