From: Bart Van Assche <bvanassche@acm.org>
To: Luis Chamberlain <mcgrof@kernel.org>,
axboe@kernel.dk, damien.lemoal@wdc.com, ming.lei@redhat.com,
martin.petersen@oracle.com, satyat@google.com
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] block: add initial kdoc over the request_queue
Date: Sun, 28 Jun 2020 13:53:50 -0700 [thread overview]
Message-ID: <9bdf8661-f616-7cd3-b78c-4a00424a0bac@acm.org> (raw)
In-Reply-To: <20200623220311.8033-2-mcgrof@kernel.org>
On 2020-06-23 15:03, Luis Chamberlain wrote:
> +/**
> + * struct request_queue - block device driver request queue
Since request queues are used as a communication channel between the
block layer core and block drivers and since the block layer core
creates request queues, I propose to leave out the word "driver".
> + * @debugfs_mutex: used to protect access to the @debugfs_dir
> + * @blk_trace: used by blktrace to keep track of setup / tracing
> + * @debugfs_dir: directory created to place debugfs information. This is always
> + * created for make_request and request-based block drivers upon
> + * initialization. blktrace requires for this directory to be created,
> + * and so it will be created on demand if its block driver type does not
> + * create it opon initialization.
> + *
> + * The request_queue is used to manage incoming block layer device driver
> + * requests. We have three main type of block driver types which end up making
> + * use of the request_queue:
"incoming" is correct from the perspective of the block driver but not
from the perspective of the block layer core. How about describing
request queues as a communication channel between the block layer core
and block drivers?
Thanks,
Bart.
next prev parent reply other threads:[~2020-06-28 20:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-23 22:03 [PATCH 0/2] block: kdocify the request_queue Luis Chamberlain
2020-06-23 22:03 ` [PATCH 1/2] block: add initial kdoc over " Luis Chamberlain
2020-06-24 0:33 ` Damien Le Moal
2020-06-24 7:22 ` Johannes Thumshirn
2020-06-28 20:53 ` Bart Van Assche [this message]
2020-06-23 22:03 ` [PATCH 2/2] block: move request_queue member docs to kdoc Luis Chamberlain
2020-06-24 0:46 ` Damien Le Moal
2020-06-24 7:23 ` Johannes Thumshirn
2020-06-28 21:23 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9bdf8661-f616-7cd3-b78c-4a00424a0bac@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@wdc.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mcgrof@kernel.org \
--cc=ming.lei@redhat.com \
--cc=satyat@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).