From: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To: Damien Le Moal <Damien.LeMoal@wdc.com>, Coly Li <colyli@suse.de>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"hare@suse.com" <hare@suse.com>, "hch@lst.de" <hch@lst.de>,
"axboe@kernel.dk" <axboe@kernel.dk>
Cc: "linux-bcache@vger.kernel.org" <linux-bcache@vger.kernel.org>,
"kbusch@kernel.org" <kbusch@kernel.org>,
Hannes Reinecke <hare@suse.de>, Jens Axboe <axboe@fb.com>,
Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
Shaun Tancheff <shaun.tancheff@seagate.com>
Subject: Re: [RFC PATCH v2 1/4] block: change REQ_OP_ZONE_RESET from 6 to 13
Date: Mon, 18 May 2020 05:09:23 +0000 [thread overview]
Message-ID: <BYAPR04MB4965F50C13415E486F519DC986B80@BYAPR04MB4965.namprd04.prod.outlook.com> (raw)
In-Reply-To: BY5PR04MB69005621AE920061F7FD383CE7B80@BY5PR04MB6900.namprd04.prod.outlook.com
On 5/17/20 5:33 PM, Damien Le Moal wrote:
> As Chaitanya pointed out, this is already used. Please rebase on Jens
> block/for-5.8/block branch.
>
> I do not see any problem with this change, but as Christoph commented, since
> zone reset does not transfer any data, I do not really see the necessity for
> this. Zone reset is indeed data-destructive, but it is not a "write" command.
> But following DISCARD and having the op number as an odd number is OK I think.
Let's keep reset consistent with discard and write-zeroes.
next prev parent reply other threads:[~2020-05-18 5:09 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-16 3:54 [RFC PATCH v2 0/4] block layer change necessary for bcache zoned device support Coly Li
2020-05-16 3:54 ` [RFC PATCH v2 1/4] block: change REQ_OP_ZONE_RESET from 6 to 13 Coly Li
2020-05-16 4:06 ` Chaitanya Kulkarni
2020-05-16 9:33 ` Coly Li
2020-05-16 12:38 ` Christoph Hellwig
2020-05-16 12:44 ` Coly Li
2020-05-16 12:50 ` Christoph Hellwig
2020-05-16 13:05 ` Coly Li
2020-05-16 15:36 ` Christoph Hellwig
2020-05-17 5:30 ` Coly Li
2020-05-18 6:53 ` Hannes Reinecke
2020-05-18 6:56 ` Damien Le Moal
2020-05-18 0:33 ` Damien Le Moal
2020-05-18 5:09 ` Chaitanya Kulkarni [this message]
2020-05-16 3:54 ` [RFC PATCH v2 2/4] block: block: change REQ_OP_ZONE_RESET_ALL from 8 to 15 Coly Li
2020-05-18 0:36 ` Damien Le Moal
2020-05-16 3:54 ` [RFC PATCH v2 3/4] block: remove queue_is_mq restriction from blk_revalidate_disk_zones() Coly Li
2020-05-16 12:40 ` Christoph Hellwig
2020-05-16 13:13 ` Coly Li
2020-05-16 15:35 ` Christoph Hellwig
2020-05-18 1:07 ` Damien Le Moal
2020-05-18 0:39 ` Damien Le Moal
2020-05-16 3:54 ` [RFC PATCH v2 4/4] block: set bi_size to REQ_OP_ZONE_RESET bio Coly Li
2020-05-16 12:53 ` Christoph Hellwig
2020-05-18 0:59 ` Damien Le Moal
2020-05-18 2:32 ` Coly Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR04MB4965F50C13415E486F519DC986B80@BYAPR04MB4965.namprd04.prod.outlook.com \
--to=chaitanya.kulkarni@wdc.com \
--cc=Damien.LeMoal@wdc.com \
--cc=Johannes.Thumshirn@wdc.com \
--cc=axboe@fb.com \
--cc=axboe@kernel.dk \
--cc=colyli@suse.de \
--cc=hare@suse.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=shaun.tancheff@seagate.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).