From: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To: Logan Gunthorpe <logang@deltatee.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
Omar Sandoval <osandov@fb.com>
Cc: Michael Moese <mmoese@suse.de>, Theodore Ts'o <tytso@mit.edu>,
Johannes Thumshirn <jthumshirn@suse.de>,
Stephen Bates <sbates@raithlin.com>
Subject: Re: [PATCH blktests 00/12] Fix nvme block test issues
Date: Mon, 15 Jul 2019 17:14:03 +0000 [thread overview]
Message-ID: <BYAPR04MB574921F8E6F38535AD161F3286CF0@BYAPR04MB5749.namprd04.prod.outlook.com> (raw)
In-Reply-To: 20190712235742.22646-1-logang@deltatee.com
Thanks Logan for doing this. I am overall okay with overall with
these changes.
Once you post V2 I'll test it on my machine.
On 07/12/2019 04:58 PM, Logan Gunthorpe wrote:
> Hi,
>
> This patchset cleans up a number of issues and pain points
> I've had with getting the nvme blktests to pass and run cleanly.
>
> The first three patches are meant to fix the Generation Counter
> issue that's been discussed before but hasn't been fixed in months.
> I primarily use a slightly fixed up patch posted by Michael Moese[1]
> but add another patch to properly test the Generation Counter that
> would no longer be tested otherwise.
>
> I've also taken it a step further to filter out more of the discovery
> information so that we are less fragile against churn and less dependant
> on the version of nvme-cli in use. This should also fix the issue discussed
> in [2].
>
> Patches 4 through 7 fix a number of smaller issues I've found with
> individual tests.
>
> Patches 8 through 10 implement a system to ensure the nvme tests
> clean themselves up properly especially when ctrl-c is used to
> interrupt a test (working with the tests before this was a huge
> pain seeing, when you ctrl-c, you have to either manually clean
> up the nvmet configuration or reboot to get the system in a state
> where it's sane to run the tests again).
>
> Patches 11 and 12 make some minor changes that allow running the
> tests with the nvme modules built into the kernel.
>
> With these patches, plus a couple I've sent to the nvme list for the
> kernel, I can consistently pass the entire nvme suite with the
> exception of the lockdep false-positive with nvme/012 that still
> seems to be in a bit of contention[3].
>
> Thanks,
>
> Logan
>
> [1] https://github.com/osandov/blktests/pull/34
> [2] https://lore.kernel.org/linux-block/20190505150611.15776-4-minwoo.im.dev@gmail.com/
> [3] https://lore.kernel.org/lkml/20190214230058.196511-22-bvanassche@acm.org/
>
> --
>
> Logan Gunthorpe (11):
> nvme: More agressively filter the discovery output
> nvme: Add new test to verify the generation counter
> nvme/003,004: Add missing calls to nvme disconnect
> nvme/005: Don't rely on modprobing to set the multipath paramater
> nvme/015: Ensure the namespace is flushed not the char device
> nvme/018: Ignore error message generated by nvme read
> check: Add the ability to call a cleanup function after a test ends
> nvme: Cleanup modprobe lines into helper functions
> nvme: Ensure all ports and subsystems are removed on cleanup
> common: Use sysfs instead of modinfo for _have_module_param()
> nvme: Ignore errors when removing modules
>
> Michael Moese (1):
> Add filter function for nvme discover
>
> check | 9 +
> common/rc | 18 +-
> tests/nvme/002 | 10 +-
> tests/nvme/002.out | 6003 +-------------------------------------------
> tests/nvme/003 | 6 +-
> tests/nvme/003.out | 1 +
> tests/nvme/004 | 6 +-
> tests/nvme/004.out | 1 +
> tests/nvme/005 | 16 +-
> tests/nvme/006 | 6 +-
> tests/nvme/007 | 6 +-
> tests/nvme/008 | 6 +-
> tests/nvme/009 | 5 +-
> tests/nvme/010 | 6 +-
> tests/nvme/011 | 6 +-
> tests/nvme/012 | 6 +-
> tests/nvme/013 | 6 +-
> tests/nvme/014 | 6 +-
> tests/nvme/015 | 5 +-
> tests/nvme/016 | 6 +-
> tests/nvme/016.out | 9 +-
> tests/nvme/017 | 8 +-
> tests/nvme/017.out | 9 +-
> tests/nvme/018 | 8 +-
> tests/nvme/019 | 6 +-
> tests/nvme/020 | 5 +-
> tests/nvme/021 | 6 +-
> tests/nvme/022 | 6 +-
> tests/nvme/023 | 6 +-
> tests/nvme/024 | 6 +-
> tests/nvme/025 | 6 +-
> tests/nvme/026 | 6 +-
> tests/nvme/027 | 6 +-
> tests/nvme/028 | 6 +-
> tests/nvme/029 | 6 +-
> tests/nvme/030 | 72 +
> tests/nvme/030.out | 2 +
> tests/nvme/rc | 64 +
> 38 files changed, 208 insertions(+), 6163 deletions(-)
> create mode 100755 tests/nvme/030
> create mode 100644 tests/nvme/030.out
>
> --
> 2.17.1
>
next prev parent reply other threads:[~2019-07-15 17:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-12 23:57 [PATCH blktests 00/12] Fix nvme block test issues Logan Gunthorpe
2019-07-12 23:57 ` [PATCH blktests 01/12] Add filter function for nvme discover Logan Gunthorpe
2019-07-12 23:57 ` [PATCH blktests 03/12] nvme: Add new test to verify the generation counter Logan Gunthorpe
2019-07-12 23:57 ` [PATCH blktests 04/12] nvme/003,004: Add missing calls to nvme disconnect Logan Gunthorpe
2019-07-12 23:57 ` [PATCH blktests 05/12] nvme/005: Don't rely on modprobing to set the multipath paramater Logan Gunthorpe
2019-07-12 23:57 ` [PATCH blktests 06/12] nvme/015: Ensure the namespace is flushed not the char device Logan Gunthorpe
2019-07-12 23:57 ` [PATCH blktests 07/12] nvme/018: Ignore error message generated by nvme read Logan Gunthorpe
2019-07-15 7:15 ` [PATCH blktests 07/12] nvme/018: Ignore error message generated by nvme read] Johannes Thumshirn
2019-07-15 15:40 ` Logan Gunthorpe
2019-07-12 23:57 ` [PATCH blktests 08/12] check: Add the ability to call a cleanup function after a test ends Logan Gunthorpe
2019-07-12 23:57 ` [PATCH blktests 09/12] nvme: Cleanup modprobe lines into helper functions Logan Gunthorpe
2019-07-12 23:57 ` [PATCH blktests 10/12] nvme: Ensure all ports and subsystems are removed on cleanup Logan Gunthorpe
2019-07-12 23:57 ` [PATCH blktests 11/12] common: Use sysfs instead of modinfo for _have_module_param() Logan Gunthorpe
2019-07-15 7:21 ` Johannes Thumshirn
2019-07-15 15:41 ` Logan Gunthorpe
2019-07-12 23:57 ` [PATCH blktests 12/12] nvme: Ignore errors when removing modules Logan Gunthorpe
2019-07-13 0:01 ` [PATCH blktests 00/12] Fix nvme block test issues Logan Gunthorpe
2019-07-15 17:14 ` Chaitanya Kulkarni [this message]
[not found] ` <20190712235742.22646-3-logang@deltatee.com>
2019-07-15 23:07 ` [PATCH blktests 02/12] nvme: More agressively filter the discovery output Omar Sandoval
2019-07-15 23:14 ` [PATCH blktests 00/12] Fix nvme block test issues Omar Sandoval
2019-07-15 23:16 ` Logan Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR04MB574921F8E6F38535AD161F3286CF0@BYAPR04MB5749.namprd04.prod.outlook.com \
--to=chaitanya.kulkarni@wdc.com \
--cc=jthumshirn@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=logang@deltatee.com \
--cc=mmoese@suse.de \
--cc=osandov@fb.com \
--cc=sbates@raithlin.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).