From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: "Javier González" <javier@javigon.com>
Cc: "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Christoph Hellwig" <hch@lst.de>,
"Matias Bjørling" <mb@lightnvm.io>,
linux-block@vger.kernel.org,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] : Switch to use new generic UUID API
Date: Thu, 24 Jan 2019 16:13:33 +0200 [thread overview]
Message-ID: <CAHp75Vfd=B-AP=7KNFiDU-qER9BjB0Qw9Lyp+hb8x94NfQiZyA@mail.gmail.com> (raw)
In-Reply-To: <9E0FD459-75F2-4EF1-9310-8FCDF6F87604@javigon.com>
On Thu, Jan 24, 2019 at 3:45 PM Javier González <javier@javigon.com> wrote:
> > On 24 Jan 2019, at 14.36, Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> > On Thu, Jan 24, 2019 at 3:19 PM Javier González <javier@javigon.com> wrote:
> >>> On 24 Jan 2019, at 13.16, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> >>> header.uuid is defined using __u8 type, I'm not sure we can use guid_t there.
> >>
> >> We can turn it into a guid_t and bump the minor version.
> >
> > It's not so easy. __uXX types are dedicated for external APIs. guid_t
> > is kernel internal type disregard of (still) presence some uapi bits.
> > So, the question is those __uXX types in the driver definition is a
> > simple mistake, (weird) style decision, or what?
> >
>
> I would define it as a mistake and I think it is worth fixing it. At the
> moment we are only using this uuid for recovery purposes, to discard
> data from a different pblk instance,
Does this come from outside of the kernel in any mean (user space,
data from device, etc)?
It sounds to me like it does. In this case there is no mistake and we
may not use guid_t there.
> so there should not be a big impact
> outside of pblk itself. Am I missing something?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-01-24 14:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 14:30 [PATCH v1] : Switch to use new generic UUID API Andy Shevchenko
2019-01-21 8:47 ` Christoph Hellwig
2019-01-24 12:16 ` Andy Shevchenko
2019-01-24 13:17 ` Javier González
2019-01-24 13:36 ` Andy Shevchenko
2019-01-24 13:45 ` Javier González
2019-01-24 14:13 ` Andy Shevchenko [this message]
2019-01-24 14:36 ` Javier González
2019-01-24 16:38 ` Andy Shevchenko
2019-01-24 16:41 ` Javier González
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75Vfd=B-AP=7KNFiDU-qER9BjB0Qw9Lyp+hb8x94NfQiZyA@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=hch@lst.de \
--cc=javier@javigon.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mb@lightnvm.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).