linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To: Minwoo Im <minwoo.im.dev@gmail.com>, Omar Sandoval <osandov@osandov.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH 2/3] nvme: 016: fix nvmet pass data with loop
Date: Mon, 6 May 2019 16:26:10 +0000	[thread overview]
Message-ID: <SN6PR04MB452726B60D050C3A88A7456C86300@SN6PR04MB4527.namprd04.prod.outlook.com> (raw)
In-Reply-To: 20190505150611.15776-3-minwoo.im.dev@gmail.com

We need to get rid of the string comparison here.
On 05/05/2019 08:06 AM, Minwoo Im wrote:
> The following commit has affected the result of genctr and treq field
> printed:
>
> genctr would increment two times per a subsystem due to
>    Commit b662a078 ("nvmet: enable Discovery Controller AENs")
>
> treq field would be printed out to support TP 8005:
>    nvmet driver:
>      Commit 9b95d2fb ("nvmet: expose support for fabrics SQ flow control
>                        disable in treq")
>    nvme-cli:
>      Commit 2cf370c3 ("fabrics: support fabrics sq flow control disable")
>
> Signed-off-by: Minwoo Im <minwoo.im.dev@gmail.com>
> ---
>   tests/nvme/016.out | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/nvme/016.out b/tests/nvme/016.out
> index 59bd293..8599066 100644
> --- a/tests/nvme/016.out
> +++ b/tests/nvme/016.out
> @@ -1,11 +1,11 @@
>   Running nvme/016
>
> -Discovery Log Number of Records 1, Generation counter 1
> +Discovery Log Number of Records 1, Generation counter 2
>   =====Discovery Log Entry 0======
>   trtype:  loop
>   adrfam:  pci
>   subtype: nvme subsystem
> -treq:    not specified
> +treq:    not specified, sq flow control disable supported
>   portid:  X
>   trsvcid:
>   subnqn:  blktests-subsystem-1
>


  reply	other threads:[~2019-05-06 16:26 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-05 15:06 [PATCH 0/3] blktests: nvme: Fix pass data of nvmet TCs Minwoo Im
2019-05-05 15:06 ` [PATCH 2/3] nvme: 016: fix nvmet pass data with loop Minwoo Im
2019-05-06 16:26   ` Chaitanya Kulkarni [this message]
2019-05-05 15:06 ` [PATCH 3/3] nvme: 017: " Minwoo Im
2019-05-06 16:25   ` Chaitanya Kulkarni
     [not found] ` <20190505150611.15776-2-minwoo.im.dev@gmail.com>
     [not found]   ` <SN6PR04MB45274C423AA7C3CC3DBB5ED586300@SN6PR04MB4527.namprd04.prod.outlook.com>
2019-05-06 16:38     ` [PATCH 1/3] nvme: 002: " Minwoo Im
2019-05-06 16:46       ` Chaitanya Kulkarni
2019-05-06 16:54         ` Minwoo Im
2019-05-06 17:47           ` Chaitanya Kulkarni
2019-05-06 20:13             ` Minwoo Im
2019-05-06 23:01               ` Chaitanya Kulkarni
2019-05-06 23:23                 ` Minwoo Im
2019-05-07  1:38                   ` Chaitanya Kulkarni
2019-05-09  5:51                   ` Chaitanya Kulkarni
2019-05-09  6:15                     ` Minwoo Im
2019-05-07  6:20           ` Johannes Thumshirn
2019-05-07 10:23             ` Minwoo Im
2019-05-09  5:52               ` Chaitanya Kulkarni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SN6PR04MB452726B60D050C3A88A7456C86300@SN6PR04MB4527.namprd04.prod.outlook.com \
    --to=chaitanya.kulkarni@wdc.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=minwoo.im.dev@gmail.com \
    --cc=osandov@osandov.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).