From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2001DC433B4 for ; Tue, 20 Apr 2021 11:09:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D57D961363 for ; Tue, 20 Apr 2021 11:09:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231815AbhDTLKC (ORCPT ); Tue, 20 Apr 2021 07:10:02 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:16778 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231837AbhDTLKC (ORCPT ); Tue, 20 Apr 2021 07:10:02 -0400 Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 13KB3aO8104884; Tue, 20 Apr 2021 07:09:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : sender : content-transfer-encoding : mime-version; s=pp1; bh=ZhWvtftjOrH2GeCDWVLlc2mk4GkaRut3/FuTuUHI3Nc=; b=nWAJj74eFZDjS3CjkAO/VEFLcS7IihY+A2kNfHNRsPRJJQ+BcCaLyZmZ4EHYukD825qx xwa3jzWnUGtNAsjMQUOE9nS5rgjaFfvBmFaWF72/4NCXV3/f/97SryqtESBwAYU70uAU 6/xTOwicG/eEYcAZmV0QpLNgbCSSJJeot4DDptzvZscFoCsiihjv9vx4zEg0nbhOvgfC LTQW0nYGOVRFVli/spfjekerxnmtt5EkuxOnwkfi71rpHgitRD/D5n6g5D0uFblqrumq SwNnEA0IFupVVn2yoPsN4rT0LlA++VVcRoQ8RGHQ2J9Hg0WpmpWPz+lmBopFPWjagmxL 5w== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 381vu6244s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 20 Apr 2021 07:09:16 -0400 Received: from m0098393.ppops.net (m0098393.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 13KB52oL112340; Tue, 20 Apr 2021 07:09:15 -0400 Received: from ppma03fra.de.ibm.com (6b.4a.5195.ip4.static.sl-reverse.com [149.81.74.107]) by mx0a-001b2d01.pphosted.com with ESMTP id 381vu6241s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 20 Apr 2021 07:09:15 -0400 Received: from pps.filterd (ppma03fra.de.ibm.com [127.0.0.1]) by ppma03fra.de.ibm.com (8.16.0.43/8.16.0.43) with SMTP id 13KB7r62023998; Tue, 20 Apr 2021 11:09:12 GMT Received: from b06avi18878370.portsmouth.uk.ibm.com (b06avi18878370.portsmouth.uk.ibm.com [9.149.26.194]) by ppma03fra.de.ibm.com with ESMTP id 37yqa88wk4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 20 Apr 2021 11:09:11 +0000 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06avi18878370.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 13KB8jHr37552580 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 20 Apr 2021 11:08:45 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BEE3211C058; Tue, 20 Apr 2021 11:09:08 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id AC20811C04A; Tue, 20 Apr 2021 11:09:08 +0000 (GMT) Received: from t480-pf1aa2c2.fritz.box (unknown [9.145.82.95]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Tue, 20 Apr 2021 11:09:08 +0000 (GMT) Received: from bblock by t480-pf1aa2c2.fritz.box with local (Exim 4.94) (envelope-from ) id 1lYoFg-003KHD-4o; Tue, 20 Apr 2021 13:09:08 +0200 Date: Tue, 20 Apr 2021 13:09:08 +0200 From: Benjamin Block To: Muneendra Kumar M Cc: Benjamin Block , linux-block@vger.kernel.org, linux-scsi@vger.kernel.org, tj@kernel.org, linux-nvme@lists.infradead.org, hare@suse.de, jsmart2021@gmail.com, emilne@redhat.com, mkumar@redhat.com, Steffen Maier Subject: Re: [PATCH v9 03/13] nvme: Added a newsysfs attribute appid_store Message-ID: References: <1617750397-26466-1-git-send-email-muneendra.kumar@broadcom.com> <1617750397-26466-4-git-send-email-muneendra.kumar@broadcom.com> Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: Sender: Benjamin Block X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: zcptgf3ihHXFLAETO78_af4mW8pN6rea X-Proofpoint-GUID: 8hHrwkPl_tvoHfnwBMJtC7wYNo-cY0e1 Content-Transfer-Encoding: quoted-printable X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.761 definitions=2021-04-20_02:2021-04-19,2021-04-20 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 priorityscore=1501 mlxscore=0 phishscore=0 lowpriorityscore=0 adultscore=0 mlxlogscore=999 spamscore=0 clxscore=1011 bulkscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104060000 definitions=main-2104200085 Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Tue, Apr 20, 2021 at 12:24:41PM +0530, Muneendra Kumar M wrote: > Hi Benjamin, >=20 > >> --- > >> drivers/nvme/host/fc.c | 73 > >> +++++++++++++++++++++++++++++++++++++++++- > >> 1 file changed, 72 insertions(+), 1 deletion(-) >=20 > > Hmm, I wonder why only NVMe-FC? Or is this just for the moment? We also > > have the FC transport class for SCSI; I assume this could feed the same > > IDs into the LLDs. > > At present it supports only for SCSI-FC . It does? By adding it to the implementation under `drivers/nvme/host/`? I am confused. I see it adds the sysfs-attribute to `nvme_fc_attrs`, how would that be added to a FC Host that does not have a NVMe 'personality'? I was assuming this only ever appears under `/sys/class/fc` if the LLDD registers itself with the NVMe subsystem (presumably via `nvme_fc_register_localport()`). zFCP, for example, does not do that, but we do implement the SCSI FC transport class in `drivers/scsi/scsi_transport_fc.c`. > In future we are adding the support for NVMe-FC > But to make it generic and avoid duplication we added this under > /sys/class/fc . >=20 > Ewan was mentioning that at some point there is a plan to decouple > the FC transport somewhat so that there is a layer that represents the > FC stuff regardless of the FC4 type (SCSI, NVMe). When we have this > layer we can move the things accordingly. >=20 --=20 Best Regards, Benjamin Block / Linux on IBM Z Kernel Development / IBM Sys= tems IBM Deutschland Research & Development GmbH / https://www.ibm.com/pri= vacy Vorsitz. AufsR.: Gregor Pillen / Gesch=E4ftsf=FChrung: Dirk = Wittkopp Sitz der Gesellschaft: B=F6blingen / Registergericht: AmtsG Stuttgart, HRB = 243294