linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Omar Kilani <omar.kilani@gmail.com>
Cc: linux-block@vger.kernel.org
Subject: Re: Deadlock in wbt / rq-qos
Date: Tue, 15 Jun 2021 17:22:43 +0800	[thread overview]
Message-ID: <YMhxY9svDeVApu95@T590> (raw)
In-Reply-To: <CA+8F9hggf7jOcGRxvBoa8FYxQs8ZV+XueVAd9BodpQQP_+8Pdw@mail.gmail.com>

On Sun, Jun 13, 2021 at 08:49:47AM -0700, Omar Kilani wrote:
> Hi there,
> 
> I appear to have stumbled upon a deadlock in wbt or rq-qos.
> 
> My journal of a lot of data points is over here:
> 
> https://github.com/openzfs/zfs/issues/12204
> 
> I initially deadlocked on RHEL 8.4's 4.18.0-305.3.1.el8_4.x86_64
> kernel, but the code in blk-wbt.c / blk-rq-qos.c is functionally
> identical to 5.13.0-rc5, so I tried that and I'm able to deadlock that
> as well. I believe the same code exists all the way back to 5.0.1.

Recently Jan Kara fixed one rq-qos deadlock issue, can you check if
the following patch fixes your issue?

https://lore.kernel.org/linux-block/e14aeaa7-45a3-b2f0-7738-3613189ae1d4@kernel.dk/T/#t

 
Thanks, 
Ming


  parent reply	other threads:[~2021-06-15  9:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-13 15:49 Deadlock in wbt / rq-qos Omar Kilani
2021-06-13 17:03 ` Omar Kilani
2021-06-14 20:26   ` Omar Kilani
2021-06-15  9:22 ` Ming Lei [this message]
     [not found]   ` <CA+8F9hjFDE9b31-qsxsVJf4SV9Ctr-mwOJrsw0kVeC7DdN=5XQ@mail.gmail.com>
2021-06-15 14:07     ` Ming Lei
2021-06-16 15:06       ` Omar Kilani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YMhxY9svDeVApu95@T590 \
    --to=ming.lei@redhat.com \
    --cc=linux-block@vger.kernel.org \
    --cc=omar.kilani@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).