From: Luis Chamberlain <mcgrof@kernel.org>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: schmitzmic@gmail.com, linux-raid@vger.kernel.org,
linux-scsi@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
axboe@kernel.dk, hch@lst.de, efremov@linux.com, song@kernel.org,
jejb@linux.ibm.com, martin.petersen@oracle.com,
viro@zeniv.linux.org.uk, hare@suse.de, jack@suse.cz,
ming.lei@redhat.com, tj@kernel.org
Subject: Re: [PATCH v3 0/3] last batch of add_disk() error handling conversions
Date: Fri, 22 Oct 2021 10:32:12 -0700 [thread overview]
Message-ID: <YXL1nJVQzfDfVyq8@bombadil.infradead.org> (raw)
In-Reply-To: <YXLwF1jit131Nb5u@bombadil.infradead.org>
On Fri, Oct 22, 2021 at 10:08:39AM -0700, Luis Chamberlain wrote:
> On Fri, Oct 22, 2021 at 10:06:07AM +0900, Tetsuo Handa wrote:
> > On 2021/10/22 1:38, Luis Chamberlain wrote:
> > > I rebased Tetsuo Handa's patch onto the latest linux-next as this
> > > series depends on it, and so I am sending it part of this series as
> > > without it, this won't apply. Tetsuo, does the rebase of your patch
> > > look OK?
> >
> > OK, though I wanted my fix to be sent to upstream and stable before this series.
>
> Sure, absolutely, your patch is certainly separate and is needed as a
> fix downstream to stable it would seem.
>
> > > If it is not too much trouble, I'd like to ask for testing for the
> > > ataflop changes from Michael Schmitz, if possible, that is he'd just
> > > have to merge Tetsuo's rebased patch and the 2nd patch in this series.
> > > This is all rebased on linux-next tag 20211020.
> >
> > Yes, please.
> >
> > After this series, I guess we can remove "bool registered[NUM_DISK_MINORS];" like below
> > due to (unit[drive].disk[type] != NULL) == (unit[drive].registered[type] == true).
>
> Sounds good.
>
> > Regarding this series, setting unit[drive].registered[type] = true in ataflop_probe() is
> > pointless because atari_floppy_cleanup() checks unit[i].disk[type] != NULL for calling
> > del_gendisk().
>
> I see, will fix.
Actually just not doing it for that case seems odd, so I would prefer
the removal of the bool registered to be a separate patch to make it
clearer.
Luis
next prev parent reply other threads:[~2021-10-22 17:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 16:38 [PATCH v3 0/3] last batch of add_disk() error handling conversions Luis Chamberlain
2021-10-21 16:38 ` [PATCH v3 1/3] ataflop: remove ataflop_probe_lock mutex Luis Chamberlain
2021-10-21 16:38 ` [PATCH v3 2/3] block: make __register_blkdev() return an error Luis Chamberlain
2021-10-21 16:38 ` [PATCH v3 3/3] block: add __must_check for *add_disk*() callers Luis Chamberlain
2021-10-22 1:06 ` [PATCH v3 0/3] last batch of add_disk() error handling conversions Tetsuo Handa
2021-10-22 2:33 ` Michael Schmitz
2021-10-22 7:21 ` Michael Schmitz
2021-10-22 17:08 ` Luis Chamberlain
2021-10-22 17:32 ` Luis Chamberlain [this message]
2021-10-24 0:03 ` Michael Schmitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXL1nJVQzfDfVyq8@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=axboe@kernel.dk \
--cc=efremov@linux.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=jejb@linux.ibm.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=schmitzmic@gmail.com \
--cc=song@kernel.org \
--cc=tj@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).