From: Jens Axboe <axboe@kernel.dk>
To: Bart Van Assche <bvanassche@acm.org>,
Hou Tao <houtao1@huawei.com>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: linux-block@vger.kernel.org, bpf <bpf@vger.kernel.org>,
Network Development <netdev@vger.kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
hare@suse.com, osandov@fb.com, ming.lei@redhat.com,
damien.lemoal@wdc.com, Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>
Subject: Re: [RFC PATCH 1/2] block: add support for redirecting IO completion through eBPF
Date: Mon, 21 Oct 2019 08:45:33 -0600 [thread overview]
Message-ID: <b09f97a5-4097-6ac4-00fd-27a77c5d15dd@kernel.dk> (raw)
In-Reply-To: <737d9d3f-e72c-ac31-6b2a-997202a302bd@acm.org>
On 10/21/19 7:48 AM, Bart Van Assche wrote:
> On 10/21/19 6:42 AM, Hou Tao wrote:
>> Your suggestion is much simpler, so there will be no need for adding a new
>> program type, and all things need to be done are adding a raw tracepoint,
>> moving bpf_ccpu into struct request, and letting a BPF program to modify it.
>
> blk-mq already supports processing completions on the CPU that submitted
> a request so it's not clear to me why any changes in the block layer are
> being proposed for redirecting I/O completions?
That's where I'm getting confused as well. I'm not against adding BPF
functionality to the block layer, but this one seems a bit contrived.
--
Jens Axboe
next prev parent reply other threads:[~2019-10-21 14:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 12:28 [RFC PATCH 0/2] block: use eBPF to redirect IO completion Hou Tao
2019-10-14 12:28 ` [RFC PATCH 1/2] block: add support for redirecting IO completion through eBPF Hou Tao
2019-10-15 21:04 ` Alexei Starovoitov
2019-10-16 7:05 ` Hannes Reinecke
2019-10-21 13:42 ` Hou Tao
2019-10-21 13:48 ` Bart Van Assche
2019-10-21 14:45 ` Jens Axboe [this message]
2019-10-14 12:28 ` [RFC PATCH 2/2] selftests/bpf: add test program for redirecting IO completion CPU Hou Tao
2019-10-15 1:20 ` [RFC PATCH 0/2] block: use eBPF to redirect IO completion Bob Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b09f97a5-4097-6ac4-00fd-27a77c5d15dd@kernel.dk \
--to=axboe@kernel.dk \
--cc=alexei.starovoitov@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=bvanassche@acm.org \
--cc=damien.lemoal@wdc.com \
--cc=daniel@iogearbox.net \
--cc=hare@suse.com \
--cc=houtao1@huawei.com \
--cc=kafai@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=osandov@fb.com \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).