linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: hch@infradead.org, linux-block@vger.kernel.org, axboe@kernel.dk
Subject: Re: [PATCH v3 0/8] block: first batch of add_disk() error handling conversions
Date: Wed, 1 Sep 2021 13:19:44 +0900	[thread overview]
Message-ID: <cc6470a2-7e32-c582-2c45-1358d3f6de1b@I-love.SAKURA.ne.jp> (raw)
In-Reply-To: <20210830212538.148729-1-mcgrof@kernel.org>

On 2021/08/31 6:25, Luis Chamberlain wrote:
> Jens,
> 
> I think this first set is ready, but pending review of just two patches:
> 
>   * mmc/core/block
>   * dm
> 
> All other patches have a respective Reviewed-by tag. The above two
> patches were integrated back into the series once I understood
> Christoph's concerns, and adjusted the patch as such.
> 
> This goes rebased onto your for-next as of today. If anyone wants to
> explore the pending full set this is up on my linux-next branch
> 20210830-for-axboe-add-disk-error-handling-next [0].

Are the changes by add_disk() made atomically against the caller?
If there is a moment where "struct block_device_operations"->open can be
called when add_disk() might still fail, how is it protected from the
kfree() path?

> 
> [0] https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git/log/?h=20210830-for-axboe-add-disk-error-handling-next
> 
> Luis Chamberlain (8):
>   scsi/sd: add error handling support for add_disk()
>   scsi/sr: add error handling support for add_disk()
>   nvme: add error handling support for add_disk()
>   mmc/core/block: add error handling support for add_disk()
>   md: add error handling support for add_disk()
>   dm: add add_disk() error handling
>   loop: add error handling support for add_disk()
>   nbd: add error handling support for add_disk()
> 
>  drivers/block/loop.c     | 9 ++++++++-
>  drivers/block/nbd.c      | 6 +++++-
>  drivers/md/dm.c          | 4 +++-
>  drivers/md/md.c          | 7 ++++++-
>  drivers/mmc/core/block.c | 7 ++++++-
>  drivers/nvme/host/core.c | 9 ++++++++-
>  drivers/scsi/sd.c        | 6 +++++-
>  drivers/scsi/sr.c        | 5 ++++-
>  8 files changed, 45 insertions(+), 8 deletions(-)
> 


  parent reply	other threads:[~2021-09-01  4:20 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-30 21:25 [PATCH v3 0/8] block: first batch of add_disk() error handling conversions Luis Chamberlain
2021-08-30 21:25 ` [PATCH v3 1/8] scsi/sd: add error handling support for add_disk() Luis Chamberlain
2021-09-06  6:13   ` Hannes Reinecke
2021-09-07  1:29   ` Ming Lei
2021-09-13 17:21     ` Luis Chamberlain
2021-08-30 21:25 ` [PATCH v3 2/8] scsi/sr: " Luis Chamberlain
2021-09-06  6:13   ` Hannes Reinecke
2021-09-07  1:37   ` Ming Lei
2021-09-13 17:26     ` Luis Chamberlain
2021-08-30 21:25 ` [PATCH v3 3/8] nvme: " Luis Chamberlain
2021-09-06  6:16   ` Hannes Reinecke
2021-09-06  8:09     ` Christoph Hellwig
2021-09-06  8:09   ` Christoph Hellwig
2021-08-30 21:25 ` [PATCH v3 4/8] mmc/core/block: " Luis Chamberlain
2021-09-06 17:10   ` Ulf Hansson
2021-08-30 21:25 ` [PATCH v3 5/8] md: " Luis Chamberlain
2021-09-06  6:17   ` Hannes Reinecke
2021-08-30 21:25 ` [PATCH v3 6/8] dm: add add_disk() error handling Luis Chamberlain
2021-09-06  6:19   ` Hannes Reinecke
2021-08-30 21:25 ` [PATCH v3 7/8] loop: add error handling support for add_disk() Luis Chamberlain
2021-09-06  6:19   ` Hannes Reinecke
2021-08-30 21:25 ` [PATCH v3 8/8] nbd: " Luis Chamberlain
2021-09-06  6:20   ` Hannes Reinecke
2021-09-01  4:19 ` Tetsuo Handa [this message]
2021-09-01  5:30   ` [PATCH v3 0/8] block: first batch of add_disk() error handling conversions Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cc6470a2-7e32-c582-2c45-1358d3f6de1b@I-love.SAKURA.ne.jp \
    --to=penguin-kernel@i-love.sakura.ne.jp \
    --cc=axboe@kernel.dk \
    --cc=hch@infradead.org \
    --cc=linux-block@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).