linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Alexey Dobriyan <adobriyan@gmail.com>, axboe@kernel.dk
Cc: linux-block@vger.kernel.org, damien.lemoal@wdc.com
Subject: Re: [PATCH] block: support arbitrary zone size
Date: Mon, 10 Feb 2020 14:23:37 -0800	[thread overview]
Message-ID: <db1b4fee-dbd1-1b0f-9ea8-b00de1d30063@acm.org> (raw)
In-Reply-To: <20200210220816.GA7769@avx2>

On 2/10/20 2:08 PM, Alexey Dobriyan wrote:
> -	return (get_capacity(disk) + zone_sectors - 1) >> ilog2(zone_sectors);
> +	return div64_u64(get_capacity(disk) + zone_sectors - 1, zone_sectors);

This kind of change impacts the performance negatively of ZNS devices 
for which the zone size is a power of two. I don't think it's fair to 
make others pay a price for a feature that is only needed for one single 
device.

Bart.

  parent reply	other threads:[~2020-02-10 22:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-10 22:08 [PATCH] block: support arbitrary zone size Alexey Dobriyan
2020-02-10 22:20 ` [PATCH v2] " Alexey Dobriyan
2020-02-10 22:57   ` Damien Le Moal
2020-02-10 23:06   ` Martin K. Petersen
2020-02-10 23:28   ` Matias Bjørling
2020-02-11 17:16     ` Alexey Dobriyan
2020-02-11  9:16   ` Javier González
2020-02-12 20:00   ` Christoph Hellwig
2020-02-10 22:23 ` Bart Van Assche [this message]
2020-02-10 22:33 ` [PATCH] " Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=db1b4fee-dbd1-1b0f-9ea8-b00de1d30063@acm.org \
    --to=bvanassche@acm.org \
    --cc=adobriyan@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=damien.lemoal@wdc.com \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).