From: Bart Van Assche <bvanassche@acm.org>
To: Jan Kara <jack@suse.cz>
Cc: John Lenton <john.lenton@canonical.com>,
Kai-Heng Feng <kaihengfeng@me.com>, Jens Axboe <axboe@kernel.dk>,
Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
linux-block@vger.kernel.org,
jean-baptiste.lallement@canonical.com
Subject: Re: [PATCH] loop: Don't change loop device under exclusive opener
Date: Wed, 7 Aug 2019 11:45:02 -0700 [thread overview]
Message-ID: <e8a14811-7091-dc0a-dcc6-38ff597bddc3@acm.org> (raw)
In-Reply-To: <20190807094520.GB14658@quack2.suse.cz>
On 8/7/19 2:45 AM, Jan Kara wrote:
> On Mon 05-08-19 09:41:39, Bart Van Assche wrote:
>> A new kernel warning is triggered by blktests block/001 that did not happen
>> without this patch. Reverting commit 89e524c04fa9 ("loop: Fix mount(2)
>> failure due to race with LOOP_SET_FD") makes that kernel warning disappear.
>> Is this reproducible on your setup?
>
> Thanks for report! Hum, no, it seems the warning doesn't trigger in my test
> VM. But reviewing the mentioned commit with fresh head, I can see where I
> did a mistake during my conversion of blkdev_get(). Does attached patch fix
> the warning for you?
Hi Jan,
That patch indeed fixes the warning. Feel free to add my Tested-by.
Thanks,
Bart.
next prev parent reply other threads:[~2019-08-07 18:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-16 14:01 [PATCH] loop: Don't change loop device under exclusive opener Jan Kara
2019-05-16 20:44 ` Jens Axboe
2019-05-27 12:29 ` Jan Kara
2019-05-27 13:34 ` Jens Axboe
2019-07-18 8:15 ` Kai-Heng Feng
2019-07-30 9:29 ` Jan Kara
2019-07-30 9:36 ` John Lenton
2019-07-30 10:16 ` Jan Kara
2019-07-30 13:36 ` Jan Kara
2019-07-30 17:59 ` Kai-Heng Feng
2019-07-30 19:17 ` Jens Axboe
2019-07-30 21:11 ` John Lenton
2019-07-31 8:56 ` Jan Kara
2019-08-05 16:41 ` Bart Van Assche
2019-08-05 21:01 ` Tetsuo Handa
2019-08-07 9:45 ` Jan Kara
2019-08-07 18:45 ` Bart Van Assche [this message]
2019-08-08 13:37 ` Jens Axboe
2019-07-30 10:16 ` Tetsuo Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8a14811-7091-dc0a-dcc6-38ff597bddc3@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=jack@suse.cz \
--cc=jean-baptiste.lallement@canonical.com \
--cc=john.lenton@canonical.com \
--cc=kaihengfeng@me.com \
--cc=linux-block@vger.kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).