From: "Michael N. Moran" <mike@mnmoran.org>
To: linux-bluetooth@vger.kernel.org
Cc: "Michael N. Moran" <mike@mnmoran.org>
Subject: [PATCH BlueZ] The meshctl sock_write() max_len variable is declared as a uint8_t, which causes the calculation of the GATT MTU to be truncated when the MTU (write_mtu) is greater than 259. This error causes incorrect segmentation.
Date: Sat, 28 Sep 2019 10:14:03 -0400 [thread overview]
Message-ID: <1569680043-2874-2-git-send-email-mike@mnmoran.org> (raw)
In-Reply-To: <1569680043-2874-1-git-send-email-mike@mnmoran.org>
From: "Michael N. Moran" <mike@mnmoran.org>
---
tools/mesh/gatt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/mesh/gatt.c b/tools/mesh/gatt.c
index 0a942d4..c9e789c 100644
--- a/tools/mesh/gatt.c
+++ b/tools/mesh/gatt.c
@@ -189,7 +189,7 @@ static bool sock_write(struct io *io, void *user_data)
struct write_data *data = user_data;
struct iovec iov[2];
uint8_t sar;
- uint8_t max_len;
+ uint16_t max_len;
if (data == NULL)
return true;
--
1.8.3.1
prev parent reply other threads:[~2019-09-28 14:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-28 14:14 [PATCH BlueZ] meshctl truncates GATT MTU Michael N. Moran
2019-09-28 14:14 ` Michael N. Moran [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1569680043-2874-2-git-send-email-mike@mnmoran.org \
--to=mike@mnmoran.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).