From: "Pali Rohár" <pali.rohar@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] tools/hcidump: Decode FastStream, aptX Low Latency, aptX HD and LDAC
Date: Wed, 23 Jan 2019 18:54:48 +0100 [thread overview]
Message-ID: <20190123175448.cdkdpnk6i5r4rzjs@pali> (raw)
In-Reply-To: <8D9BABBE-2BBC-4BFE-BF7C-3BE24AF4DD10@holtmann.org>
[-- Attachment #1: Type: text/plain, Size: 1347 bytes --]
On Wednesday 23 January 2019 18:46:18 Marcel Holtmann wrote:
> Hi Pali,
>
> > ---
> > tools/parser/avdtp.c | 58 +++++++++++++++++++++++++++++++++++++++++++++++++---
> > 1 file changed, 55 insertions(+), 3 deletions(-)
> >
> > diff --git a/tools/parser/avdtp.c b/tools/parser/avdtp.c
> > index 18569c895..a21410f5a 100644
> > --- a/tools/parser/avdtp.c
> > +++ b/tools/parser/avdtp.c
> > @@ -155,6 +155,12 @@ static char *vndcodec2str(uint32_t vendor, uint16_t vndcodec)
> > {
> > if (vendor == 0x0000004f && vndcodec == 0x0001)
> > return "aptX";
> > + else if (vendor == 0x0000000a && vndcodec == 0x0001)
> > + return "FastStream";
> > + else if (vendor == 0x0000000a && vndcodec == 0x0002)
> > + return "aptX Low Latency";
> > + else if (vendor == 0x000000d7 && vndcodec == 0x0024)
> > + return "aptX HD";
> > else if (vendor == 0x0000012d && vndcodec == 0x00aa)
> > return "LDAC";
> > return "Unknown”;
>
> lets keep the focus on btmon support since nobody should be using hcidump anymore.
In btmon I already implemented it and patches are now merged. I just
found another place where this capability parsing is implemented and
based on fact that users still use hcidump I quickly looked at it and
implemented this parsing.
> Regards
>
> Marcel
>
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2019-01-23 17:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-23 17:45 [PATCH] tools/hcidump: Decode FastStream, aptX Low Latency, aptX HD and LDAC Pali Rohár
2019-01-23 17:46 ` Marcel Holtmann
2019-01-23 17:54 ` Pali Rohár [this message]
2019-01-30 8:15 ` Pasi Kärkkäinen
2019-01-30 12:06 ` Pali Rohár
2019-01-30 12:24 ` Luiz Augusto von Dentz
2019-02-01 12:43 ` Pasi Kärkkäinen
2019-02-06 11:43 ` Pali Rohár
2019-02-24 13:19 ` Pasi Kärkkäinen
2019-03-05 12:26 ` Pali Rohár
2019-04-10 8:29 ` Pali Rohár
2019-06-07 13:07 ` Pali Rohár
2019-10-14 11:07 ` Pali Rohár
2020-02-09 13:05 ` Pali Rohár
2020-04-14 23:00 ` Pali Rohár
2020-05-03 11:14 ` Pali Rohár
2020-08-08 13:24 ` Pali Rohár
2020-09-29 21:34 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190123175448.cdkdpnk6i5r4rzjs@pali \
--to=pali.rohar@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).