From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH v2 4/8] gatt: Write back the handle to Handle property
Date: Wed, 30 Jan 2019 15:54:20 +0200 [thread overview]
Message-ID: <20190130135424.2091-4-luiz.dentz@gmail.com> (raw)
In-Reply-To: <20190130135424.2091-1-luiz.dentz@gmail.com>
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
If the application has set an attribute with Handle set to 0 inform the
allocated handle by writting the Handle property.
---
src/gatt-database.c | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/src/gatt-database.c b/src/gatt-database.c
index 025f777eb..b159786ea 100644
--- a/src/gatt-database.c
+++ b/src/gatt-database.c
@@ -2617,6 +2617,18 @@ fail:
gatt_db_attribute_write_result(attrib, id, BT_ATT_ERROR_UNLIKELY);
}
+static void write_handle(struct GDBusProxy *proxy, uint16_t handle)
+{
+ DBusMessageIter iter;
+
+ /* Check if the attribute has the Handle property */
+ if (!g_dbus_proxy_get_property(proxy, "Handle", &iter))
+ return;
+
+ g_dbus_proxy_set_property_basic(proxy, "Handle", DBUS_TYPE_UINT16,
+ &handle, NULL, NULL, NULL);
+}
+
static bool database_add_desc(struct external_service *service,
struct external_desc *desc)
{
@@ -2645,6 +2657,11 @@ static bool database_add_desc(struct external_service *service,
desc->handled = true;
+ if (!handle) {
+ handle = gatt_db_attribute_get_handle(desc->attrib);
+ write_handle(desc->proxy, handle);
+ }
+
return true;
}
@@ -2810,6 +2827,11 @@ static bool database_add_chrc(struct external_service *service,
if (!database_add_cep(service, chrc))
return false;
+ if (!handle) {
+ handle = gatt_db_attribute_get_handle(chrc->attrib);
+ write_handle(chrc->proxy, handle);
+ }
+
/* Handle the descriptors that belong to this characteristic. */
for (entry = queue_get_entries(service->descs); entry;
entry = entry->next) {
@@ -2868,6 +2890,11 @@ static bool database_add_service(struct external_service *service)
if (!service->attrib)
return false;
+ if (!handle) {
+ handle = gatt_db_attribute_get_handle(service->attrib);
+ write_handle(service->proxy, handle);
+ }
+
database_add_includes(service);
entry = queue_get_entries(service->chrcs);
--
2.17.2
next prev parent reply other threads:[~2019-01-30 13:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-30 13:54 [PATCH v2 1/8] doc/gatt-api: Add Handle property Luiz Augusto von Dentz
2019-01-30 13:54 ` [PATCH v2 2/8] shared/gatt-db: Allow passing 0 as handle to gatt_db_insert_* Luiz Augusto von Dentz
2019-01-30 13:54 ` [PATCH v2 3/8] gatt: Implement Handle property Luiz Augusto von Dentz
2019-01-30 13:54 ` Luiz Augusto von Dentz [this message]
2019-01-30 13:54 ` [PATCH v2 5/8] client: Enable Handle property for GATT attributes Luiz Augusto von Dentz
2019-01-30 13:54 ` [PATCH v2 6/8] client: Enable setting attribute handles Luiz Augusto von Dentz
2019-01-30 13:54 ` [PATCH v2 7/8] client: Enable list-attributes to print local attributes Luiz Augusto von Dentz
2019-01-30 13:54 ` [PATCH v2 8/8] client: Don't expose pointer value in attribute path Luiz Augusto von Dentz
2019-01-31 12:17 ` [PATCH v2 1/8] doc/gatt-api: Add Handle property Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190130135424.2091-4-luiz.dentz@gmail.com \
--to=luiz.dentz@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).