From: Jian-Hong Pan <jian-hong@endlessm.com>
To: Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
Daniel Drake <drake@endlessm.com>
Cc: linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
Jian-Hong Pan <jian-hong@endlessm.com>
Subject: [PATCH] Bluetooth: btrtl: HCI reset on close for RTL8822BE
Date: Fri, 21 Jun 2019 16:58:40 +0800 [thread overview]
Message-ID: <20190621085840.6341-1-jian-hong@endlessm.com> (raw)
Realtek RTL8822BE BT chip on ASUS X420FA cannot be turned on correctly
after on-off several times. Bluetooth daemon sets BT mode failed when
this issue happens.
bluetoothd[1576]: Failed to set mode: Failed (0x03)
If BT is tunred off, then turned on again, it works correctly again.
This patch makes RTL8822BE BT reset on close to fix this issue.
Signed-off-by: Jian-Hong Pan <jian-hong@endlessm.com>
---
drivers/bluetooth/btrtl.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c
index 208feef63de4..7e9930f0f231 100644
--- a/drivers/bluetooth/btrtl.c
+++ b/drivers/bluetooth/btrtl.c
@@ -608,10 +608,11 @@ int btrtl_download_firmware(struct hci_dev *hdev,
case RTL_ROM_LMP_8723A:
case RTL_ROM_LMP_3499:
return btrtl_setup_rtl8723a(hdev, btrtl_dev);
+ case RTL_ROM_LMP_8822B:
+ set_bit(HCI_QUIRK_RESET_ON_CLOSE, &hdev->quirks);
case RTL_ROM_LMP_8723B:
case RTL_ROM_LMP_8821A:
case RTL_ROM_LMP_8761A:
- case RTL_ROM_LMP_8822B:
return btrtl_setup_rtl8723b(hdev, btrtl_dev);
default:
rtl_dev_info(hdev, "rtl: assuming no firmware upload needed\n");
--
2.20.1
next reply other threads:[~2019-06-21 8:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-21 8:58 Jian-Hong Pan [this message]
2019-06-24 4:53 ` [PATCH] Bluetooth: btrtl: HCI reset on close for RTL8822BE Daniel Drake
2019-06-24 6:21 ` [PATCH v2] Bluetooth: btrtl: HCI reset on close for Realtek BT chip Jian-Hong Pan
2019-06-25 5:10 ` Daniel Drake
2019-06-25 5:43 ` Marcel Holtmann
2019-06-25 8:30 ` [PATCH v3] " Jian-Hong Pan
2019-07-01 7:45 ` Daniel Drake
2019-07-06 10:51 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190621085840.6341-1-jian-hong@endlessm.com \
--to=jian-hong@endlessm.com \
--cc=drake@endlessm.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).