From: "Michał Lowas-Rzechonek" <michal.lowas-rzechonek@silvair.com>
To: Inga Stotland <inga.stotland@intel.com>
Cc: linux-bluetooth@vger.kernel.org, brian.gix@intel.com
Subject: Re: [PATCH BlueZ] mesh: Init keyring storage directory on node Attach()
Date: Thu, 18 Jul 2019 10:59:23 +0200 [thread overview]
Message-ID: <20190718085923.4ljvk3t3avqdh24d@mlowasrzechonek2133> (raw)
In-Reply-To: <20190718040126.5152-1-inga.stotland@intel.com>
On 07/17, Inga Stotland wrote:
>This adds initialization of keyring storage directory when
>a mesh node is attached successfully.
>---
> mesh/node.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
>diff --git a/mesh/node.c b/mesh/node.c
>index 652551756..6b784bf8d 100644
>--- a/mesh/node.c
>+++ b/mesh/node.c
>@@ -1656,6 +1656,14 @@ static void get_managed_objects_cb(struct l_dbus_message *msg, void *user_data)
> } else
> goto fail;
>
>+ /*
>+ * TODO: For now always initialize directory for storing
>+ * keyring info. Need to figure out what checks need
>+ * to be performed to do this conditionally, i.e., presence of
>+ * Provisioner interface, etc.
>+ */
>+ init_storage_dir(node);
I think the keyring should be initialized as soon ad the node is
created. The keyring should always exist, and should contain at least
the local device key - otherwise DevKeySend can't be used to talk to
local Config Server.
--
Michał Lowas-Rzechonek <michal.lowas-rzechonek@silvair.com>
Silvair http://silvair.com
Jasnogórska 44, 31-358 Krakow, POLAND
next prev parent reply other threads:[~2019-07-18 8:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-18 4:01 [PATCH BlueZ] mesh: Init keyring storage directory on node Attach() Inga Stotland
2019-07-18 8:59 ` Michał Lowas-Rzechonek [this message]
2019-07-18 16:36 ` Gix, Brian
2019-07-18 18:54 ` Michal Lowas-Rzechonek
2019-07-18 17:08 ` Gix, Brian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190718085923.4ljvk3t3avqdh24d@mlowasrzechonek2133 \
--to=michal.lowas-rzechonek@silvair.com \
--cc=brian.gix@intel.com \
--cc=inga.stotland@intel.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).