From: Brian Gix <brian.gix@intel.com>
To: linux-bluetooth@vger.kernel.org
Cc: inga.stotland@intel.com, brian.gix@intel.com
Subject: [PATCH BlueZ 3/3] mesh: Fix leaked message reference
Date: Fri, 22 May 2020 13:57:56 -0700 [thread overview]
Message-ID: <20200522205756.230907-4-brian.gix@intel.com> (raw)
In-Reply-To: <20200522205756.230907-1-brian.gix@intel.com>
---
mesh/manager.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/mesh/manager.c b/mesh/manager.c
index 0242bb9e9..a7383e4d5 100644
--- a/mesh/manager.c
+++ b/mesh/manager.c
@@ -228,6 +228,7 @@ static void add_start(void *user_data, int err)
"Failed to start provisioning initiator");
l_dbus_send(dbus_get_bus(), reply);
+ l_dbus_message_unref(add_pending->msg);
add_pending->msg = NULL;
}
@@ -264,7 +265,6 @@ static struct l_dbus_message *add_node_call(struct l_dbus *dbus,
/* Invoke Prov Initiator */
add_pending = l_new(struct add_data, 1);
- add_pending->msg = l_dbus_message_ref(msg);
memcpy(add_pending->uuid, uuid, 16);
add_pending->node = node;
add_pending->agent = node_get_agent(node);
@@ -277,6 +277,7 @@ static struct l_dbus_message *add_node_call(struct l_dbus *dbus,
goto fail;
}
+ add_pending->msg = l_dbus_message_ref(msg);
initiator_start(PB_ADV, uuid, 99, 60, add_pending->agent, add_start,
add_data_get, add_cmplt, node, add_pending);
--
2.25.4
next prev parent reply other threads:[~2020-05-22 20:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 20:57 [PATCH BlueZ 0/3] mesh: Static Analysis clean-up Brian Gix
2020-05-22 20:57 ` [PATCH BlueZ 1/3] mesh: Fix using uninitialized bytes Brian Gix
2020-05-22 20:57 ` [PATCH BlueZ 2/3] mesh: Fix leaked mesh_net allocation Brian Gix
2020-05-22 23:36 ` [BlueZ,2/3] " bluez.test.bot
2020-05-22 20:57 ` Brian Gix [this message]
2020-05-22 23:36 ` [BlueZ,3/3] mesh: Fix leaked message reference bluez.test.bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200522205756.230907-4-brian.gix@intel.com \
--to=brian.gix@intel.com \
--cc=inga.stotland@intel.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).