From: Brian Gix <brian.gix@intel.com>
To: linux-bluetooth@vger.kernel.org
Cc: inga.stotland@intel.com, brian.gix@intel.com
Subject: [PATCH BlueZ v2 1/4] mesh: Fix using uninitialized bytes
Date: Fri, 22 May 2020 14:13:06 -0700 [thread overview]
Message-ID: <20200522211309.233824-2-brian.gix@intel.com> (raw)
In-Reply-To: <20200522211309.233824-1-brian.gix@intel.com>
Fixes two problems found with static analysis
---
mesh/crypto.c | 1 +
mesh/node.c | 2 ++
2 files changed, 3 insertions(+)
diff --git a/mesh/crypto.c b/mesh/crypto.c
index 99536594b..70b96c51b 100644
--- a/mesh/crypto.c
+++ b/mesh/crypto.c
@@ -553,6 +553,7 @@ bool mesh_crypto_packet_build(bool ctl, uint8_t ttl,
if (seq > SEQ_MASK)
return false;
+ packet[0] = 0;
l_put_be32(seq, packet + 1);
packet[1] = (ctl ? CTL : 0) | (ttl & TTL_MASK);
diff --git a/mesh/node.c b/mesh/node.c
index dd28dfd77..49ba7c885 100644
--- a/mesh/node.c
+++ b/mesh/node.c
@@ -1596,6 +1596,8 @@ static void get_managed_objects_cb(struct l_dbus_message *msg, void *user_data)
/* Generate device and primary network keys */
l_getrandom(dev_key, sizeof(dev_key));
l_getrandom(net_key.old_key, sizeof(net_key.old_key));
+ memcpy(net_key.new_key, net_key.old_key,
+ sizeof(net_key.old_key));
net_key.net_idx = PRIMARY_NET_IDX;
net_key.phase = KEY_REFRESH_PHASE_NONE;
--
2.25.4
next prev parent reply other threads:[~2020-05-22 21:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 21:13 [PATCH BlueZ v2 0/4] mesh: Static Analysis clean-up Brian Gix
2020-05-22 21:13 ` Brian Gix [this message]
2020-05-22 21:13 ` [PATCH BlueZ v2 2/4] mesh: Fix leaked mesh_net allocation Brian Gix
2020-05-22 23:37 ` [BlueZ,v2,2/4] " bluez.test.bot
2020-05-22 21:13 ` [PATCH BlueZ v2 3/4] mesh: Fix leaked message reference Brian Gix
2020-05-22 23:37 ` [BlueZ,v2,3/4] " bluez.test.bot
2020-05-22 21:13 ` [PATCH BlueZ v2 4/4] mesh: Destroy PB-ADV queue when provisioning done Brian Gix
2020-05-22 23:37 ` [BlueZ,v2,4/4] " bluez.test.bot
2020-05-25 14:15 ` [PATCH BlueZ v2 0/4] mesh: Static Analysis clean-up Gix, Brian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200522211309.233824-2-brian.gix@intel.com \
--to=brian.gix@intel.com \
--cc=inga.stotland@intel.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).